Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2430223003: Revert of [inspector] Turn on inspector by default (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 1 month ago
Reviewers:
kozy, dgozman, Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [inspector] Turn on inspector by default (patchset #1 id:1 of https://codereview.chromium.org/2395763002/ ) Reason for revert: Has test failures on windows and blocks landing a test driver fix. Original issue's description: > [inspector] Turn on inspector by default > > BUG=chromium:635948 > > Committed: https://crrev.com/8146402c69044affff0e95f9641eee532fb70312 > Cr-Commit-Position: refs/heads/master@{#40380} TBR=kozyatinskiy@chromium.org,dgozman@chromium.org,yangguo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:635948 Committed: https://crrev.com/3c91cdea1dffe05b6aea1f3a6c8131a1d4f6f2cd Cr-Commit-Position: refs/heads/master@{#40422}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build_overrides/v8.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of [inspector] Turn on inspector by default
4 years, 2 months ago (2016-10-19 07:03:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430223003/1
4 years, 2 months ago (2016-10-19 07:03:50 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 08:56:27 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:05:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c91cdea1dffe05b6aea1f3a6c8131a1d4f6f2cd
Cr-Commit-Position: refs/heads/master@{#40422}

Powered by Google App Engine
This is Rietveld 408576698