WebRTC: Remove Dr Memory bots.

WebRTC: Remove Dr Memory bots.

Chromium has decided to turn down Dr Memory as a tool and rely on the
LLVM Sanitizers instead (bug 655521). Since the Dr Memory toolchain is
no longer maintained we should also get rid of our bots.

R=kjellander@chromium.org
BUG=657266
Committed: https://chromium.googlesource.com/chromium/tools/build/+/6c1a9ea869dd1608dfd44ad4719739239d2efa06

[ehmaldonado_chromium, 2016-10-19 09:44:34]

Patchset #1 (id:1) has been deleted

[kjellander_chromium, 2016-10-19 11:13:31]

https://codereview.chromium.org/2430193003/diff/20001/masters/master.client.w...
File masters/master.client.webrtc/slaves.cfg (left):

https://codereview.chromium.org/2430193003/diff/20001/masters/master.client.w...
masters/master.client.webrtc/slaves.cfg:130: 'hostname': 'vm346-m3',
Please add this and the VM below to the above pool of machines

https://codereview.chromium.org/2430193003/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/webrtc/builders.py (left):

https://codereview.chromium.org/2430193003/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/webrtc/builders.py:939: 'chromium_apply_config':
['drmemory_light'],
'drmemory_light' was only referenced from our bots AFAICS, so you have to remove
it from the config.py of the chromium recipe module. Otherwise you'll fail the
coverage presubmit test.

Also remove them from line 22:
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/...
and add phajdan.jr@ as reviewer.

https://codereview.chromium.org/2430193003/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/webrtc/builders.py:949: 'chromium_apply_config':
['drmemory_full'],
Same with 'drmemory_full'

[ehmaldonado_chromium, 2016-10-19 13:53:33]

ehmaldonado@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[ehmaldonado_chromium, 2016-10-19 13:53:33]

PTAL

[kjellander_chromium, 2016-10-19 14:09:18]

https://codereview.chromium.org/2430193003/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium/config.py (right):

https://codereview.chromium.org/2430193003/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/config.py:22: MEMORY_TOOLS = ('memcheck',)
Can you remove this now? I think we can use an enable_memcheck variable instead.

https://codereview.chromium.org/2430193003/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/config.py:85: memory_tool =
Single(basestring, required=False),
can you refactor this to:
enable_memcheck = Single(bool, empty_val=False, required=False),
?

https://codereview.chromium.org/2430193003/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/config.py:486: def _memory_tool(c, tool):
I suggest we can remove this too.

[ehmaldonado_chromium, 2016-10-19 15:13:43]

Patchset #3 (id:60001) has been deleted

[kjellander_chromium, 2016-10-19 15:41:23]

https://codereview.chromium.org/2430193003/diff/80001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium/config.py (right):

https://codereview.chromium.org/2430193003/diff/80001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/config.py:456: def memcheck(c):
I don't think a group makes sense anymore. Just remove it here and below.

[ehmaldonado_chromium, 2016-10-19 15:57:53]

Patchset #4 (id:100001) has been deleted

[ehmaldonado_chromium, 2016-10-19 16:00:28]

https://codereview.chromium.org/2430193003/diff/80001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium/config.py (right):

https://codereview.chromium.org/2430193003/diff/80001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/config.py:456: def memcheck(c):
On 2016/10/19 15:41:23, kjellander_chromium wrote:
> I don't think a group makes sense anymore. Just remove it here and below.

It does. It means that memcheck, tsan2 and syzyasan are mutually exclusive.
https://cs.chromium.org/chromium/infra/recipes-py/recipe_engine/config.py?l=116

I renamed it back to memory_tool. enable_memcheck was not a good name for the
group.

[kjellander_chromium, 2016-10-19 17:37:33]

lgtm

[Paweł Hajdan Jr., 2016-10-20 09:23:47]

LGTM

[ehmaldonado_chromium, 2016-10-20 09:24:18]

The CQ bit was checked by ehmaldonado@chromium.org

[commit-bot: I haz the power, 2016-10-20 09:24:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 09:34:27]

Description was changed from

==========
WebRTC: Remove Dr Memory bots.

Chromium has decided to turn down Dr Memory as a tool and rely on the
LLVM Sanitizers instead (bug 655521). Since the Dr Memory toolchain is
no longer maintained we should also get rid of our bots.

R=kjellander@chromium.org
BUG=657266
==========

to

==========
WebRTC: Remove Dr Memory bots.

Chromium has decided to turn down Dr Memory as a tool and rely on the
LLVM Sanitizers instead (bug 655521). Since the Dr Memory toolchain is
no longer maintained we should also get rid of our bots.

R=kjellander@chromium.org
BUG=657266

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/6c1a9ea869dd1608dfd4...
==========

[commit-bot: I haz the power, 2016-10-20 09:34:29]

Committed patchset #4 (id:120001) as
https://chromium.googlesource.com/chromium/tools/build/+/6c1a9ea869dd1608dfd4...