Forward touch events from the toolbar to the NTP only if the fakebox hasn't reached the top of the …

Forward touch events from the toolbar to the NTP only if the fakebox hasn't reached the top of the NTP.

BUG=657798
Committed: https://crrev.com/1970b4776aaf2ae29d398d0b200c2c2c12a086c3
Cr-Commit-Position: refs/heads/master@{#426804}

[Bernhard Bauer, 2016-10-20 18:42:43]

The CQ bit was checked by bauerb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 18:43:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 19:22:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 19:22:04]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-10-21 09:05:27]

bauerb@chromium.org changed reviewers:
+ peconn@chromium.org

[Bernhard Bauer, 2016-10-21 09:05:28]

Please review.

[PEConn, 2016-10-21 09:49:34]

On 2016/10/21 09:05:28, Bernhard Bauer wrote:
> Please review.

LGTM - nothing jumps out at me, but I'm not confident of my understanding of the
ToolbarPhone code, potentially link mdjones@ in?

[Bernhard Bauer, 2016-10-21 09:52:31]

bauerb@chromium.org changed reviewers:
+ mdjones@chromium.org

[Bernhard Bauer, 2016-10-21 09:52:31]

Matthew, could you take a look?

[mdjones, 2016-10-21 15:02:20]

lgtm

https://codereview.chromium.org/2430153006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
(right):

https://codereview.chromium.org/2430153006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java:455:
// Forward touch events to the NTP if the toolbar is moved away, but
nit: Remove comma.

[Bernhard Bauer, 2016-10-21 15:18:59]

https://codereview.chromium.org/2430153006/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
(right):

https://codereview.chromium.org/2430153006/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java:455:
// Forward touch events to the NTP if the toolbar is moved away, but
On 2016/10/21 15:02:19, mdjones wrote:
> nit: Remove comma.

Oh right, thanks!

[Bernhard Bauer, 2016-10-21 15:19:03]

The CQ bit was checked by bauerb@chromium.org

[Bernhard Bauer, 2016-10-21 15:19:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
mdjones@chromium.org, peconn@chromium.org
Link to the patchset: https://codereview.chromium.org/2430153006/#ps20001
(title: "review")

[commit-bot: I haz the power, 2016-10-21 15:19:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 16:07:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 16:35:01]

Description was changed from

==========
Forward touch events from the toolbar to the NTP only if the fakebox hasn't
reached the top of the NTP.

BUG=657798
==========

to

==========
Forward touch events from the toolbar to the NTP only if the fakebox hasn't
reached the top of the NTP.

BUG=657798

Committed: https://crrev.com/1970b4776aaf2ae29d398d0b200c2c2c12a086c3
Cr-Commit-Position: refs/heads/master@{#426804}
==========

[commit-bot: I haz the power, 2016-10-21 16:35:02]

Patchset 2 (id:??) landed as
https://crrev.com/1970b4776aaf2ae29d398d0b200c2c2c12a086c3
Cr-Commit-Position: refs/heads/master@{#426804}