Use signal.SIGTERM instead of signal.SIGKILL to kill process.

Use signal.SIGTERM instead of signal.SIGKILL to kill process.

Since Windows does not have signal.SIGKILL, we need to use signal.SIGTERM to use the same code in both posix and Windows.

Additional changes:
- minimize scope file handler is opened.
- make more chatty for ease of understanding what happens in where.
- ignore exceptions caused in wait_terminate.
  I believe making the service running is more important than
  completely killing cloudtail the way we thought.

BUG=656846
Committed: https://chromium.googlesource.com/chromium/tools/build/+/4f6540ce526f62da04741be7d86861db8550705e

[Yoshisato Yanagisawa, 2016-10-19 02:51:19]

yyanagisawa@chromium.org changed reviewers:
+ shinyak@chromium.org, tikuta@chromium.org, ukai@chromium.org

[Yoshisato Yanagisawa, 2016-10-19 02:55:25]

Description was changed from

==========
Use signal.SIGTERM instead of signal.SIGKILL to kill process.

Additional changes:
- minimize scope file handler is opened.
- make more chatty for ease of understanding what happens in where.
- ignore exceptions caused in wait_terminate.
  I believe making the service running is more important than
  completely killing cloudtail the way we thought.

BUG=656846
==========

to

==========
Use signal.SIGTERM instead of signal.SIGKILL to kill process.

Since Windows does not have signal.SIGKILL, we need to use signal.SIGTERM to use
the same code in both posix and Windows.

Additional changes:
- minimize scope file handler is opened.
- make more chatty for ease of understanding what happens in where.
- ignore exceptions caused in wait_terminate.
  I believe making the service running is more important than
  completely killing cloudtail the way we thought.

BUG=656846
==========

[ukai, 2016-10-19 04:16:27]

lgtm

https://codereview.chromium.org/2430123002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py (right):

https://codereview.chromium.org/2430123002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py:126: os.kill(pid,
signal.SIGTERM)
cloudtail doesn't handle SIGTERM to process something?

[Yoshisato Yanagisawa, 2016-10-19 04:27:24]

https://codereview.chromium.org/2430123002/diff/1/scripts/slave/recipe_module...
File scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py (right):

https://codereview.chromium.org/2430123002/diff/1/scripts/slave/recipe_module...
scripts/slave/recipe_modules/goma/resources/cloudtail_utils.py:126: os.kill(pid,
signal.SIGTERM)
On 2016/10/19 04:16:27, ukai wrote:
> cloudtail doesn't handle SIGTERM to process something?

It seems not?

https://chromium.googlesource.com/infra/infra.git/+/master/go/src/infra/tools...

https://golang.org/pkg/os/#Signal

[Yoshisato Yanagisawa, 2016-10-19 04:37:06]

The CQ bit was checked by yyanagisawa@chromium.org

[commit-bot: I haz the power, 2016-10-19 04:37:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 04:46:50]

Description was changed from

==========
Use signal.SIGTERM instead of signal.SIGKILL to kill process.

Since Windows does not have signal.SIGKILL, we need to use signal.SIGTERM to use
the same code in both posix and Windows.

Additional changes:
- minimize scope file handler is opened.
- make more chatty for ease of understanding what happens in where.
- ignore exceptions caused in wait_terminate.
  I believe making the service running is more important than
  completely killing cloudtail the way we thought.

BUG=656846
==========

to

==========
Use signal.SIGTERM instead of signal.SIGKILL to kill process.

Since Windows does not have signal.SIGKILL, we need to use signal.SIGTERM to use
the same code in both posix and Windows.

Additional changes:
- minimize scope file handler is opened.
- make more chatty for ease of understanding what happens in where.
- ignore exceptions caused in wait_terminate.
  I believe making the service running is more important than
  completely killing cloudtail the way we thought.

BUG=656846

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/4f6540ce526f62da0474...
==========

[commit-bot: I haz the power, 2016-10-19 04:46:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/4f6540ce526f62da0474...