Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2429983002: PPC/s390: [builtins] Remove the unused AllocationSite slot from ConstructFrame. (Closed)

Created:
4 years, 2 months ago by yangtian.zi
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [builtins] Remove the unused AllocationSite slot from ConstructFrame. Port 77419488a971aa9be4da1f167cd5afe0c7537d01 Original commit message: This slot is completely unused and always undefined anyways, so there's no need to maintain the slot during object construction. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/489843f5526fafcea868451cb186fdd182ac8d5f Cr-Commit-Position: refs/heads/master@{#40441}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed extra push as suggested. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 1 3 chunks +9 lines, -8 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 1 3 chunks +9 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
JaideepBajwa
https://codereview.chromium.org/2429983002/diff/1/src/builtins/ppc/builtins-ppc.cc File src/builtins/ppc/builtins-ppc.cc (right): https://codereview.chromium.org/2429983002/diff/1/src/builtins/ppc/builtins-ppc.cc#newcode579 src/builtins/ppc/builtins-ppc.cc:579: __ Push(cp); as discussed, this Push can be removed. ...
4 years, 2 months ago (2016-10-18 22:26:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429983002/20001
4 years, 2 months ago (2016-10-19 13:50:20 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-10-19 13:50:22 UTC) #6
john.yan
lgtm
4 years, 2 months ago (2016-10-19 13:52:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429983002/20001
4 years, 2 months ago (2016-10-19 13:52:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 14:21:38 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:06:47 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/489843f5526fafcea868451cb186fdd182ac8d5f
Cr-Commit-Position: refs/heads/master@{#40441}

Powered by Google App Engine
This is Rietveld 408576698