[MD settings] content settings add site button; layout fixes

[MD settings] content settings add site button; layout fixes

This CL moves the 'Add site exception' button to an 'Add' button on the
header line of the site exceptions. The filter for the site data has
been moved into the list of sites. The remove all local cookie and
storage button has been removed from the list of cookies (it's still
available in the dialog).

Also, the misalignment of .secondary text in checkboxes and content
settings has been fixed.

BUG=654875, 655036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2
Cr-Commit-Position: refs/heads/master@{#426536}

[dschuyler, 2016-10-19 01:31:03]

Description was changed from

==========
[MD settings] content settings add site button; layout fixes

This CL moves the 'Add site exception' button to an 'Add' button on the
header line of the site exceptions. The filter for the site data has
been moved into the list of sites. The remove all local cookie and
storage button has been removed from the list of cookies (it's still
available in the dialog).

Also, the misalignment of .secondary text in checkboxes and content
settings has been fixed.

BUG=654875, 655036
==========

to

==========
[MD settings] content settings add site button; layout fixes

This CL moves the 'Add site exception' button to an 'Add' button on the
header line of the site exceptions. The filter for the site data has
been moved into the list of sites. The remove all local cookie and
storage button has been removed from the list of cookies (it's still
available in the dialog).

Also, the misalignment of .secondary text in checkboxes and content
settings has been fixed.

BUG=654875, 655036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-10-19 01:31:05]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 01:33:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 02:40:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 02:40:42]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dschuyler, 2016-10-19 18:55:26]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 18:55:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-19 18:56:41]

dschuyler@chromium.org changed reviewers:
+ dpapad@chromium.org

[dschuyler, 2016-10-19 18:56:42]

https://codereview.chromium.org/2429973003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/controls/settings_checkbox.html (left):

https://codereview.chromium.org/2429973003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/controls/settings_checkbox.html:25: 
This is redundant with settings_shared_css.html changes.

https://codereview.chromium.org/2429973003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_shared_css.html (left):

https://codereview.chromium.org/2429973003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_shared_css.html:236: 
These have become redundant.

https://codereview.chromium.org/2429973003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2429973003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_shared_css.html:167: min-width: 1em; 
/* A tighter fit than 5.14em for short buttons. */
5.14em is the Polymer default value.

https://codereview.chromium.org/2429973003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_shared_css.html:323: /*
TODO(dschuyler): add :blank when it's supported by Chrome. */
The :blank thing looks awesome because it will not 
count blank space. The :empty does count blank space.
so <div></div> is empty and <div> </div> is not empty
(both of those are or will be :blank).

https://codereview.chromium.org/2429973003/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/site_settings/site_data.html (right):

https://codereview.chromium.org/2429973003/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/site_settings/site_data.html:16: margin-top:
12px;  /* Align with <h2>. */
The h2 are not centered, they are slightly low
of center (intentionally, by request of Alan).

[dpapad, 2016-10-19 19:40:13]

https://codereview.chromium.org/2429973003/diff/20001/chrome/app/settings_str...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2429973003/diff/20001/chrome/app/settings_str...
chrome/app/settings_strings.grdp:1791: Add
I don't think this is needed anymore.  You can use the generic IDS_ADD, see
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/md_sett...

https://codereview.chromium.org/2429973003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_data.js (left):

https://codereview.chromium.org/2429973003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data.js:167:
'siteSettingsCookieRemoveConfirmation', event.model.item.site);
Is the 'siteSettingsCookieRemoveConfirmation' not used anymore? Can we fully
remove if so?

https://codereview.chromium.org/2429973003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_list.html (right):

https://codereview.chromium.org/2429973003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_list.html:50: <!-- Until
:blank is supported, this div must not contain extra
I could not find :blank documented in any W3C standards doc/draft, so I don't
think we can count on this being implemented any time soon (only firefox seems
to have it as -moz-only-whitespace). Maybe rephrase to

":empty CSS selector only works when no whitespace exists."

https://codereview.chromium.org/2429973003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_list.js (left):

https://codereview.chromium.org/2429973003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_list.js:183: if
(this.allSites ||
Are we removing the all sites view in this CL?

[commit-bot: I haz the power, 2016-10-19 21:04:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 21:04:02]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-10-20 00:02:27]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 00:03:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-20 00:05:23]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 00:05:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-20 00:06:09]

https://codereview.chromium.org/2429973003/diff/20001/chrome/app/settings_str...
File chrome/app/settings_strings.grdp (right):

https://codereview.chromium.org/2429973003/diff/20001/chrome/app/settings_str...
chrome/app/settings_strings.grdp:1791: Add
On 2016/10/19 19:40:13, dpapad wrote:
> I don't think this is needed anymore.  You can use the generic IDS_ADD, see
>
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/settings/md_sett...

Nice, thanks.

Done.

https://codereview.chromium.org/2429973003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_data.js (left):

https://codereview.chromium.org/2429973003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_data.js:167:
'siteSettingsCookieRemoveConfirmation', event.model.item.site);
On 2016/10/19 19:40:13, dpapad wrote:
> Is the 'siteSettingsCookieRemoveConfirmation' not used anymore? Can we fully
> remove if so?

done.

https://codereview.chromium.org/2429973003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_list.html (right):

https://codereview.chromium.org/2429973003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_list.html:50: <!-- Until
:blank is supported, this div must not contain extra
On 2016/10/19 19:40:13, dpapad wrote:
> I could not find :blank documented in any W3C standards doc/draft, so I don't
> think we can count on this being implemented any time soon (only firefox seems
> to have it as -moz-only-whitespace). Maybe rephrase to
> 
> ":empty CSS selector only works when no whitespace exists."

I changed the comment to include an example of the issue and
guidance about what to watch for.

https://codereview.chromium.org/2429973003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_list.js (left):

https://codereview.chromium.org/2429973003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_list.js:183: if
(this.allSites ||
On 2016/10/19 19:40:13, dpapad wrote:
> Are we removing the all sites view in this CL?

We put all sites behind a flag in an earlier CL.
In this CL we are removing category.opened, so the status
of this.allSites is no longer valuable to test (since 
the effect would be ignored).

[dpapad, 2016-10-20 00:11:02]

lgtm

[commit-bot: I haz the power, 2016-10-20 02:14:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 02:14:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dschuyler, 2016-10-20 18:15:32]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-10-20 18:15:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 18:23:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-21 13:20:24]

Description was changed from

==========
[MD settings] content settings add site button; layout fixes

This CL moves the 'Add site exception' button to an 'Add' button on the
header line of the site exceptions. The filter for the site data has
been moved into the list of sites. The remove all local cookie and
storage button has been removed from the list of cookies (it's still
available in the dialog).

Also, the misalignment of .secondary text in checkboxes and content
settings has been fixed.

BUG=654875, 655036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] content settings add site button; layout fixes

This CL moves the 'Add site exception' button to an 'Add' button on the
header line of the site exceptions. The filter for the site data has
been moved into the list of sites. The remove all local cookie and
storage button has been removed from the list of cookies (it's still
available in the dialog).

Also, the misalignment of .secondary text in checkboxes and content
settings has been fixed.

BUG=654875, 655036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2
Cr-Commit-Position: refs/heads/master@{#426536}
==========

[commit-bot: I haz the power, 2016-10-21 13:20:25]

Patchset 4 (id:??) landed as
https://crrev.com/3d8adf8d41aee5f64a004bf89ec3c0cbaa7b4cb2
Cr-Commit-Position: refs/heads/master@{#426536}