Implement all system menu title row buttons for Ash MD

Implement all system menu title row buttons for Ash MD

For the system menu in Ash material design
(--ash-md=experimental), make the following changes
to the buttons appearing in the system menu
detailed views:

* Only show the settings button in the title row
of the default views when there are corresponding
WebUI settings.

* Add support for a 'disabled' appearance to
SystemMenuButton, and use this state for the
buttons mentioned below when they are not
clickable.

* Hide the non-MD settings button for the Cast
detailed view (there is no Settings button in the
MD spec for this view).

* Hide the non-MD settings button and replace it
with a settings gear in the title rows for the
Bluetooth, IME, Network, and a11y detailed views.

* Add a network info icon to the network detailed
view title row.

* Add a help button to the a11y detailed view
title row.

BUG=642136, 632102, 632036, 632025, 632128, 631831
TEST=ash_unittests

Committed: https://crrev.com/a47ee24b2f8dcfa97b81c2d6af7a774278d6be6a
Cr-Commit-Position: refs/heads/master@{#426328}

[tdanderson, 2016-10-18 20:48:47]

Description was changed from

==========
Implement all system menu title row buttons for Ash MD

WIP.

BUG=tba
TEST=ash_unittests
==========

to

==========
Implement all system menu title row buttons for Ash MD

WIP.

BUG=642136,632102,632036,632025,632128,631831
TEST=ash_unittests
==========

[tdanderson, 2016-10-18 20:49:07]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 20:50:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tdanderson, 2016-10-18 20:57:19]

Description was changed from

==========
Implement all system menu title row buttons for Ash MD

WIP.

BUG=642136,632102,632036,632025,632128,631831
TEST=ash_unittests
==========

to

==========
Implement all system menu title row buttons for Ash MD

For the system menu in Ash material design
(--ash-md=experimental), make the following changes
to the buttons appearing in the system menu
detailed views:

* Only show the settings button in the title row
of the default views when there are corresponding
WebUI settings.

* Add support for a 'disabled' appearance to
SystemMenuButton, and use this state for the
buttons mentioned below when they are not
clickable.

* Hide the non-MD settings button for the Cast
detailed view (there is no Settings button in the
MD spec for this view).

* Hide the non-MD settings button and replace it
with a settings gear in the title rows for the
Bluetooth, IME, Network, and a11y detailed views.

* Add a network info icon to the network detailed
view title row.

* Add a help button to the a11y detailed view
title row.

BUG=642136,632102,632036,632025,632128,631831
TEST=ash_unittests
==========

[tdanderson, 2016-10-18 20:57:46]

tdanderson@chromium.org changed reviewers:
+ bruthig@chromium.org

[tdanderson, 2016-10-18 20:57:47]

Ben, can you please take a look?

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/network/network_state_list_detailed_view.h
(right):

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/network/network_state_list_detailed_view.h:150:
views::CustomButton* info_button_md_;
self-review: change types of these to SystemMenuButton

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/tray/spec...
File ash/common/system/tray/special_popup_row.h (right):

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/tray/spec...
ash/common/system/tray/special_popup_row.h:53: views::Button*
AddSettingsButton(views::ButtonListener* listener,
Ben, I'm thinking of killing off these Add*Button() convenience functions and
instead having all clients just create their own button and call into
AddViewToTitleRow(). See for example what I do in
NetworkStateListDetailedView::CreateExtraTitleRowButtons(). What are your
thoughts?

[tdanderson, 2016-10-18 21:07:09]

+azurewei@ as FYI. This CL removes the "Manage input..." button at the bottom of
the IME detailed view and replaces it with a settings button in the top row.
This should have no effect on the opt-in menu but I wanted to cc you just in
case. The opt-in menu still shows the "Manage input..." button at the bottom,
which you are replacing with the new row of buttons.

[commit-bot: I haz the power, 2016-10-18 21:59:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 21:59:40]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Azure Wei, 2016-10-19 01:43:02]

On 2016/10/18 21:07:09, tdanderson wrote:
> +azurewei@ as FYI. This CL removes the "Manage input..." button at the bottom
of
> the IME detailed view and replaces it with a settings button in the top row.
> This should have no effect on the opt-in menu but I wanted to cc you just in
> case. The opt-in menu still shows the "Manage input..." button at the bottom,
> which you are replacing with the new row of buttons.

Thanks for the info.
The new row of buttons will be shown for system IMEs. For third-party IME
extension, it will still show "Manage input..." button at the bottom. I'll make
it consistent with your CL to show a settings button.

[bruthig, 2016-10-19 15:43:09]

lgtm

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/network/network_state_list_detailed_view.h
(right):

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/network/network_state_list_detailed_view.h:150:
views::CustomButton* info_button_md_;
On 2016/10/18 20:57:47, tdanderson wrote:
> self-review: change types of these to SystemMenuButton

I think these should stay typed as CustomButton.

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/tiles/til...
File ash/common/system/tiles/tiles_default_view.h (right):

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/tiles/til...
ash/common/system/tiles/tiles_default_view.h:52: SystemMenuButton*
settings_button_;
Can these be typed as CustomButton?

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/tray/spec...
File ash/common/system/tray/special_popup_row.h (right):

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/tray/spec...
ash/common/system/tray/special_popup_row.h:53: views::Button*
AddSettingsButton(views::ButtonListener* listener,
On 2016/10/18 20:57:47, tdanderson wrote:
> Ben, I'm thinking of killing off these Add*Button() convenience functions and
> instead having all clients just create their own button and call into
> AddViewToTitleRow(). See for example what I do in
> NetworkStateListDetailedView::CreateExtraTitleRowButtons(). What are your
> thoughts?

As discussed offline, I think we should keep them.  It will make it easier to
migrate them to control building factory and the AddViewToTitleRow() should be
removed once the new layout managers land.

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/tray/tray...
File ash/common/system/tray/tray_utils.cc (right):

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/tray/tray...
ash/common/system/tray/tray_utils.cc:91: bool CanOpenWebUISettings(LoginStatus
status) {
It seems kind of odd that we query the TrayUtils to determine if the settings
can be shown but then ask specific delegates owned by the WmShell to actually
show the settings.  I think it would make more sense to ask each of these
delegates (or the WmShell), "CanShowSettings()" and if true, then
"ShowSettings()".

[tdanderson, 2016-10-19 19:49:32]

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/chromeos/...
File ash/common/system/chromeos/network/network_state_list_detailed_view.h
(right):

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/chromeos/...
ash/common/system/chromeos/network/network_state_list_detailed_view.h:150:
views::CustomButton* info_button_md_;
On 2016/10/19 15:43:09, bruthig wrote:
> On 2016/10/18 20:57:47, tdanderson wrote:
> > self-review: change types of these to SystemMenuButton
> 
> I think these should stay typed as CustomButton.

Done.

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/tiles/til...
File ash/common/system/tiles/tiles_default_view.h (right):

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/tiles/til...
ash/common/system/tiles/tiles_default_view.h:52: SystemMenuButton*
settings_button_;
On 2016/10/19 15:43:09, bruthig wrote:
> Can these be typed as CustomButton?

Done.

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/tray/spec...
File ash/common/system/tray/special_popup_row.h (right):

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/tray/spec...
ash/common/system/tray/special_popup_row.h:53: views::Button*
AddSettingsButton(views::ButtonListener* listener,
On 2016/10/19 15:43:09, bruthig wrote:
> On 2016/10/18 20:57:47, tdanderson wrote:
> > Ben, I'm thinking of killing off these Add*Button() convenience functions
and
> > instead having all clients just create their own button and call into
> > AddViewToTitleRow(). See for example what I do in
> > NetworkStateListDetailedView::CreateExtraTitleRowButtons(). What are your
> > thoughts?
> 
> As discussed offline, I think we should keep them.  It will make it easier to
> migrate them to control building factory and the AddViewToTitleRow() should be
> removed once the new layout managers land.

Acknowledged.

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/tray/tray...
File ash/common/system/tray/tray_utils.cc (right):

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/tray/tray...
ash/common/system/tray/tray_utils.cc:91: bool CanOpenWebUISettings(LoginStatus
status) {
On 2016/10/19 15:43:09, bruthig wrote:
> It seems kind of odd that we query the TrayUtils to determine if the settings
> can be shown but then ask specific delegates owned by the WmShell to actually
> show the settings.  I think it would make more sense to ask each of these
> delegates (or the WmShell), "CanShowSettings()" and if true, then
> "ShowSettings()".

Added a corresponding TODO.

[tdanderson, 2016-10-19 19:50:37]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 19:51:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bruthig, 2016-10-19 20:17:58]

slgtm

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/tray/tray...
File ash/common/system/tray/tray_utils.cc (right):

https://codereview.chromium.org/2429923002/diff/1/ash/common/system/tray/tray...
ash/common/system/tray/tray_utils.cc:91: bool CanOpenWebUISettings(LoginStatus
status) {
On 2016/10/19 19:49:31, tdanderson wrote:
> On 2016/10/19 15:43:09, bruthig wrote:
> > It seems kind of odd that we query the TrayUtils to determine if the
settings
> > can be shown but then ask specific delegates owned by the WmShell to
actually
> > show the settings.  I think it would make more sense to ask each of these
> > delegates (or the WmShell), "CanShowSettings()" and if true, then
> > "ShowSettings()".
> 
> Added a corresponding TODO.

Acknowledged.

[tdanderson, 2016-10-19 20:19:27]

The CQ bit was unchecked by tdanderson@chromium.org

[tdanderson, 2016-10-19 20:19:37]

The CQ bit was checked by tdanderson@chromium.org

[tdanderson, 2016-10-19 20:19:38]

The patchset sent to the CQ was uploaded after l-g-t-m from bruthig@chromium.org
Link to the patchset: https://codereview.chromium.org/2429923002/#ps20001
(title: "comments and tests")

[commit-bot: I haz the power, 2016-10-19 20:20:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 20:42:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 20:42:30]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tdanderson, 2016-10-19 21:35:36]

The CQ bit was checked by tdanderson@chromium.org

[tdanderson, 2016-10-19 21:35:36]

The patchset sent to the CQ was uploaded after l-g-t-m from bruthig@chromium.org
Link to the patchset: https://codereview.chromium.org/2429923002/#ps40001
(title: "OS_WIN define in tests")

[commit-bot: I haz the power, 2016-10-19 21:36:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 23:20:39]

Description was changed from

==========
Implement all system menu title row buttons for Ash MD

For the system menu in Ash material design
(--ash-md=experimental), make the following changes
to the buttons appearing in the system menu
detailed views:

* Only show the settings button in the title row
of the default views when there are corresponding
WebUI settings.

* Add support for a 'disabled' appearance to
SystemMenuButton, and use this state for the
buttons mentioned below when they are not
clickable.

* Hide the non-MD settings button for the Cast
detailed view (there is no Settings button in the
MD spec for this view).

* Hide the non-MD settings button and replace it
with a settings gear in the title rows for the
Bluetooth, IME, Network, and a11y detailed views.

* Add a network info icon to the network detailed
view title row.

* Add a help button to the a11y detailed view
title row.

BUG=642136,632102,632036,632025,632128,631831
TEST=ash_unittests
==========

to

==========
Implement all system menu title row buttons for Ash MD

For the system menu in Ash material design
(--ash-md=experimental), make the following changes
to the buttons appearing in the system menu
detailed views:

* Only show the settings button in the title row
of the default views when there are corresponding
WebUI settings.

* Add support for a 'disabled' appearance to
SystemMenuButton, and use this state for the
buttons mentioned below when they are not
clickable.

* Hide the non-MD settings button for the Cast
detailed view (there is no Settings button in the
MD spec for this view).

* Hide the non-MD settings button and replace it
with a settings gear in the title rows for the
Bluetooth, IME, Network, and a11y detailed views.

* Add a network info icon to the network detailed
view title row.

* Add a help button to the a11y detailed view
title row.

BUG=642136,632102,632036,632025,632128,631831
TEST=ash_unittests
==========

[commit-bot: I haz the power, 2016-10-19 23:20:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:12:57]

Description was changed from

==========
Implement all system menu title row buttons for Ash MD

For the system menu in Ash material design
(--ash-md=experimental), make the following changes
to the buttons appearing in the system menu
detailed views:

* Only show the settings button in the title row
of the default views when there are corresponding
WebUI settings.

* Add support for a 'disabled' appearance to
SystemMenuButton, and use this state for the
buttons mentioned below when they are not
clickable.

* Hide the non-MD settings button for the Cast
detailed view (there is no Settings button in the
MD spec for this view).

* Hide the non-MD settings button and replace it
with a settings gear in the title rows for the
Bluetooth, IME, Network, and a11y detailed views.

* Add a network info icon to the network detailed
view title row.

* Add a help button to the a11y detailed view
title row.

BUG=642136,632102,632036,632025,632128,631831
TEST=ash_unittests
==========

to

==========
Implement all system menu title row buttons for Ash MD

For the system menu in Ash material design
(--ash-md=experimental), make the following changes
to the buttons appearing in the system menu
detailed views:

* Only show the settings button in the title row
of the default views when there are corresponding
WebUI settings.

* Add support for a 'disabled' appearance to
SystemMenuButton, and use this state for the
buttons mentioned below when they are not
clickable.

* Hide the non-MD settings button for the Cast
detailed view (there is no Settings button in the
MD spec for this view).

* Hide the non-MD settings button and replace it
with a settings gear in the title rows for the
Bluetooth, IME, Network, and a11y detailed views.

* Add a network info icon to the network detailed
view title row.

* Add a help button to the a11y detailed view
title row.

BUG=642136,632102,632036,632025,632128,631831
TEST=ash_unittests

Committed: https://crrev.com/a47ee24b2f8dcfa97b81c2d6af7a774278d6be6a
Cr-Commit-Position: refs/heads/master@{#426328}
==========

[commit-bot: I haz the power, 2016-10-21 13:12:59]

Patchset 3 (id:??) landed as
https://crrev.com/a47ee24b2f8dcfa97b81c2d6af7a774278d6be6a
Cr-Commit-Position: refs/heads/master@{#426328}