Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2429913002: [TTS] Promote clicks on AMP carousel to a separate Tab. (Closed)

Created:
4 years, 2 months ago by Donn Denman
Modified:
4 years, 2 months ago
Reviewers:
Theresa
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TTS] Promote clicks on AMP carousel to a separate Tab. An AMP carousel is part of the SRP (Search Result Page) and clicking on one just does sub-frame loading. Almost everything works fine except for issue 653760 which causes the subframe to scroll up but not down. This change simply promotes clicks on the AMP carousel into a separate Tab. BUG=645325 Committed: https://crrev.com/ffd75360db3fc16ec6b4cb28c5b68b534f8ac55d Cr-Commit-Position: refs/heads/master@{#426607}

Patch Set 1 #

Patch Set 2 : Just rebase. #

Total comments: 2

Patch Set 3 : Check the URI to see if it's really and AMP link. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java View 1 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchPolicy.java View 1 2 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
Donn Denman
Theresa, PTAL. Thanks!
4 years, 2 months ago (2016-10-18 19:47:43 UTC) #3
Theresa
https://codereview.chromium.org/2429913002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java File chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java (right): https://codereview.chromium.org/2429913002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java#newcode916 chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java:916: && mSearchPanel.didTouchContent()) { I think some comments here would ...
4 years, 2 months ago (2016-10-19 16:21:02 UTC) #11
Donn Denman
Theresa, PTAL when convenient. Thanks! https://codereview.chromium.org/2429913002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java File chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java (right): https://codereview.chromium.org/2429913002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java#newcode916 chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java:916: && mSearchPanel.didTouchContent()) { On ...
4 years, 2 months ago (2016-10-20 04:57:00 UTC) #12
Theresa
lgtm
4 years, 2 months ago (2016-10-20 20:20:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429913002/40001
4 years, 2 months ago (2016-10-20 21:33:14 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-20 21:45:18 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:22:57 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ffd75360db3fc16ec6b4cb28c5b68b534f8ac55d
Cr-Commit-Position: refs/heads/master@{#426607}

Powered by Google App Engine
This is Rietveld 408576698