Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2733)

Issue 2429863002: Use TRACE_TASK_EXECUTION in SequencedWorkerPool. (Closed)

Created:
4 years, 2 months ago by fdoray
Modified:
4 years, 2 months ago
Reviewers:
danakj, gab
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TRACE_TASK_EXECUTION in SequencedWorkerPool. With this CL, SequencedWorkerPool generates an event in the "toplevel" category when it runs a task. This is the same behavior as MessageLoop, TaskScheduler and WorkerPool. BUG=611818 Committed: https://crrev.com/af4072ecf86c2c8ff7ec217e4830e2c2e5964cf7 Cr-Commit-Position: refs/heads/master@{#426994}

Patch Set 1 #

Patch Set 2 : remove unused include #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M base/threading/sequenced_worker_pool.cc View 1 2 chunks +4 lines, -8 lines 6 comments Download

Messages

Total messages: 16 (5 generated)
fdoray
PTAL
4 years, 2 months ago (2016-10-18 17:27:27 UTC) #2
gab
lgtm w/ question https://chromiumcodereview.appspot.com/2429863002/diff/20001/base/threading/sequenced_worker_pool.cc File base/threading/sequenced_worker_pool.cc (left): https://chromiumcodereview.appspot.com/2429863002/diff/20001/base/threading/sequenced_worker_pool.cc#oldcode1001 base/threading/sequenced_worker_pool.cc:1001: TRACE_HEAP_PROFILER_API_SCOPED_TASK_EXECUTION task_event( Why was this removed?
4 years, 2 months ago (2016-10-18 18:15:02 UTC) #3
fdoray
danakj@: PTAL https://codereview.chromium.org/2429863002/diff/20001/base/threading/sequenced_worker_pool.cc File base/threading/sequenced_worker_pool.cc (left): https://codereview.chromium.org/2429863002/diff/20001/base/threading/sequenced_worker_pool.cc#oldcode1001 base/threading/sequenced_worker_pool.cc:1001: TRACE_HEAP_PROFILER_API_SCOPED_TASK_EXECUTION task_event( On 2016/10/18 18:15:02, gab wrote: ...
4 years, 2 months ago (2016-10-18 19:19:29 UTC) #4
danakj
https://codereview.chromium.org/2429863002/diff/20001/base/threading/sequenced_worker_pool.cc File base/threading/sequenced_worker_pool.cc (right): https://codereview.chromium.org/2429863002/diff/20001/base/threading/sequenced_worker_pool.cc#newcode994 base/threading/sequenced_worker_pool.cc:994: TRACE_TASK_EXECUTION("SequencedWorkerPool::Inner::ThreadLoop", task); Is reordering these ok? They will not ...
4 years, 2 months ago (2016-10-20 21:05:18 UTC) #5
fdoray
danakj@: PTAnL https://codereview.chromium.org/2429863002/diff/20001/base/threading/sequenced_worker_pool.cc File base/threading/sequenced_worker_pool.cc (right): https://codereview.chromium.org/2429863002/diff/20001/base/threading/sequenced_worker_pool.cc#newcode994 base/threading/sequenced_worker_pool.cc:994: TRACE_TASK_EXECUTION("SequencedWorkerPool::Inner::ThreadLoop", task); On 2016/10/20 21:05:18, danakj wrote: ...
4 years, 2 months ago (2016-10-21 12:47:59 UTC) #6
danakj
Thanks LGTM
4 years, 2 months ago (2016-10-21 21:01:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429863002/20001
4 years, 2 months ago (2016-10-21 21:24:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/150304)
4 years, 2 months ago (2016-10-22 03:11:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429863002/20001
4 years, 2 months ago (2016-10-22 22:12:02 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-23 13:38:37 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-23 13:42:00 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/af4072ecf86c2c8ff7ec217e4830e2c2e5964cf7
Cr-Commit-Position: refs/heads/master@{#426994}

Powered by Google App Engine
This is Rietveld 408576698