Hotfix for MediaSession::OnPlayerPaused

Hotfix for MediaSession::OnPlayerPaused

There is an issue with removing a player from MediaSession when the
player is paused with the existence of pepper players. This CL fixes the
issue.

BUG=619084
Committed: https://crrev.com/20756e0ed6432c0e51d08ed902b22546314d2b14
Cr-Commit-Position: refs/heads/master@{#426194}

[Zhiqiang Zhang (Slow), 2016-10-18 12:36:28]

zqzhang@chromium.org changed reviewers:
+ avayvod@chromium.org, mlamouri@chromium.org

[Zhiqiang Zhang (Slow), 2016-10-18 12:36:28]

Ideally we need tests, but since flash joining MediaSession might go away, I
prefer not to waste too much time on the tests.

[whywhat, 2016-10-18 15:53:08]

On 2016/10/18 at 12:36:28, zqzhang wrote:
> Ideally we need tests, but since flash joining MediaSession might go away, I
prefer not to waste too much time on the tests.

Hm, I don't think there are any announced plans to completely remove Flash. So
I'd rather invest into tests.

[whywhat, 2016-10-18 15:53:58]

lgtm

[Zhiqiang Zhang (Slow), 2016-10-18 16:09:36]

The CQ bit was checked by zqzhang@chromium.org

[commit-bot: I haz the power, 2016-10-18 16:09:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 16:23:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 16:23:22]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mlamouri (slow - plz ping), 2016-10-18 16:56:05]

-myself for review, I will let avayvod@ review this given that he reviewed the
original CL.

[mlamouri (slow - plz ping), 2016-10-18 16:56:18]

On 2016/10/18 at 16:56:05, mlamouri wrote:
> -myself for review, I will let avayvod@ review this given that he reviewed the
original CL.

Amazing crossing! :)

[mlamouri (slow - plz ping), 2016-10-18 16:56:36]

mlamouri@chromium.org changed reviewers:
- mlamouri@chromium.org

[Zhiqiang Zhang (Slow), 2016-10-19 10:11:14]

The CQ bit was checked by zqzhang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 10:11:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhiqiang Zhang (Slow), 2016-10-19 10:21:16]

On 2016/10/18 15:53:08, whywhat wrote:
> Hm, I don't think there are any announced plans to completely remove Flash. So
> I'd rather invest into tests.

Mounir talked with Rachel before, and said we are likely to go without Flash,
but haven't decided yet.

[commit-bot: I haz the power, 2016-10-19 13:00:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 13:00:01]

Dry run: This issue passed the CQ dry run.

[Zhiqiang Zhang (Slow), 2016-10-19 15:00:27]

The CQ bit was checked by zqzhang@chromium.org

[Zhiqiang Zhang (Slow), 2016-10-19 15:00:28]

The patchset sent to the CQ was uploaded after l-g-t-m from avayvod@chromium.org
Link to the patchset: https://codereview.chromium.org/2429823002/#ps20001
(title: "rebased")

[commit-bot: I haz the power, 2016-10-19 15:00:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 15:12:26]

Committed patchset #2 (id:20001)

[mlamouri (slow - plz ping), 2016-10-19 17:13:43]

To clarify, without Flash means that Flash (and plugins in general) would
be excluded from media session. It's still something to consider. On the UX
side, the inconsistencies between normal behaviour and Flash behaviour
might be a problem.

On Wed, 19 Oct 2016, 16:12 commit-bot@chromium.org via
codereview.chromium.org, <reply@chromiumcodereview-hr.appspotmail.com>
wrote:

> Committed patchset #2 (id:20001)
>
> https://chromiumcodereview.appspot.com/2429823002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-10-21 13:08:29]

Description was changed from

==========
Hotfix for MediaSession::OnPlayerPaused

There is an issue with removing a player from MediaSession when the
player is paused with the existence of pepper players. This CL fixes the
issue.

BUG=619084
==========

to

==========
Hotfix for MediaSession::OnPlayerPaused

There is an issue with removing a player from MediaSession when the
player is paused with the existence of pepper players. This CL fixes the
issue.

BUG=619084

Committed: https://crrev.com/20756e0ed6432c0e51d08ed902b22546314d2b14
Cr-Commit-Position: refs/heads/master@{#426194}
==========

[commit-bot: I haz the power, 2016-10-21 13:08:30]

Patchset 2 (id:??) landed as
https://crrev.com/20756e0ed6432c0e51d08ed902b22546314d2b14
Cr-Commit-Position: refs/heads/master@{#426194}