Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2429623005: X87: [ic] Unify CallIC feedback collection and handling. (Closed)

Created:
4 years, 2 months ago by zhengxing.li
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [ic] Unify CallIC feedback collection and handling. port 308788b3069703117a9004e64c06c26137c84263 (r40397) original commit message: Consistently collect CallIC feedback in fullcodegen and Ignition, even for possibly direct eval calls, that were treated specially so far, for no apparent reason. With the upcoming SharedFunctionInfo based CallIC feedback, we might be able to even inline certain direct eval calls, if they manage to hit the eval cache. More importantly, this patch simplifies the collection and dealing with CallIC feedback (and as a side effect fixes an inconsistency with feedback for super constructor calls). BUG= Committed: https://crrev.com/572c231c98346802978f24c265092e32c56c80fd Cr-Commit-Position: refs/heads/master@{#40416}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 2 months ago (2016-10-19 02:11:43 UTC) #2
Weiliang
lgtm
4 years, 2 months ago (2016-10-19 03:00:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429623005/1
4 years, 2 months ago (2016-10-19 03:02:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 03:32:15 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:05:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/572c231c98346802978f24c265092e32c56c80fd
Cr-Commit-Position: refs/heads/master@{#40416}

Powered by Google App Engine
This is Rietveld 408576698