Also archive diff files in layout-test-results.zip.

Also archive diff files in layout-test-results.zip.

This is a followup to http://crrev.com/2414153003.
The purpose is to add diff files into the zip archives
along with actual result files.

BUG=656684, 655810
Committed: https://chromium.googlesource.com/chromium/tools/build/+/e22a1387a6f865be9becbc903fcc16d5d05b6a36

[qyearsley, 2016-10-18 16:25:29]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 16:25:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2016-10-18 16:25:51]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[commit-bot: I haz the power, 2016-10-18 17:07:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 17:07:05]

Dry run: Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/31f16e7f266ee410)

[Dirk Pranke, 2016-10-18 20:00:51]

https://codereview.chromium.org/2429573002/diff/40001/scripts/slave/chromium/...
File scripts/slave/chromium/archive_layout_test_results.py (right):

https://codereview.chromium.org/2429573002/diff/40001/scripts/slave/chromium/...
scripts/slave/chromium/archive_layout_test_results.py:48:
diff_file_list.append(os.path.join(rel_path, name))
diff_file_list isn't declared or returned? Did you mean to append this to
file_list? If so, maybe just combine _IsActualResultFile() and _IsDiffFile()?

[qyearsley, 2016-10-18 20:50:33]

https://codereview.chromium.org/2429573002/diff/40001/scripts/slave/chromium/...
File scripts/slave/chromium/archive_layout_test_results.py (right):

https://codereview.chromium.org/2429573002/diff/40001/scripts/slave/chromium/...
scripts/slave/chromium/archive_layout_test_results.py:48:
diff_file_list.append(os.path.join(rel_path, name))
On 2016/10/18 at 20:00:51, Dirk Pranke wrote:
> diff_file_list isn't declared or returned? Did you mean to append this to
file_list? If so, maybe just combine _IsActualResultFile() and _IsDiffFile()?

Right, that's what I meant -- now merged them and updated this in the latest
patchset.

[qyearsley, 2016-10-18 20:51:48]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 20:51:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 20:57:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 20:57:25]

Dry run: Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/31f2637da7c7d710)

[qyearsley, 2016-10-18 21:07:52]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 21:07:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 21:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 21:19:27]

Dry run: This issue passed the CQ dry run.

[Dirk Pranke, 2016-10-19 05:01:12]

lgtm

[qyearsley, 2016-10-19 17:00:29]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-10-19 17:00:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 17:10:33]

Description was changed from

==========
Also archive diff files in layout-test-results.zip.

This is a followup to http://crrev.com/2414153003.
The purpose is to add diff files into the zip archives
along with actual result files.

BUG=656684,655810
==========

to

==========
Also archive diff files in layout-test-results.zip.

This is a followup to http://crrev.com/2414153003.
The purpose is to add diff files into the zip archives
along with actual result files.

BUG=656684,655810

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/e22a1387a6f865be9bec...
==========

[commit-bot: I haz the power, 2016-10-19 17:10:34]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/tools/build/+/e22a1387a6f865be9bec...