Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2429313003: Server push cancellation: add metrics collection for (Closed)

Created:
4 years, 2 months ago by Zhongyi Shi
Modified:
4 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Server push cancellation: add metrics collection for 1. collecting number of stream bytes that has been pushed by the server 2. collecting number of stream bytes that has been pushed by the server but never claimed until expired. BUG=232040 Committed: https://crrev.com/b10f8ebcdc8deb79d736d6994bd92a6d5a6590ca Cr-Commit-Position: refs/heads/master@{#426547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -2 lines) Patch
M net/spdy/spdy_session.h View 2 chunks +7 lines, -0 lines 0 comments Download
M net/spdy/spdy_session.cc View 4 chunks +8 lines, -0 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 3 chunks +103 lines, -2 lines 0 comments Download
M net/spdy/spdy_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Zhongyi Shi
4 years, 2 months ago (2016-10-19 05:03:40 UTC) #2
Buck
lgtm
4 years, 2 months ago (2016-10-19 22:27:32 UTC) #3
Zhongyi Shi
Alexei, ptal!
4 years, 2 months ago (2016-10-19 22:42:46 UTC) #5
Alexei Svitkine (slow)
lgtm
4 years, 2 months ago (2016-10-20 15:04:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429313003/1
4 years, 2 months ago (2016-10-20 16:53:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 18:54:39 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:20:48 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b10f8ebcdc8deb79d736d6994bd92a6d5a6590ca
Cr-Commit-Position: refs/heads/master@{#426547}

Powered by Google App Engine
This is Rietveld 408576698