Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2429283004: histograms: Add ESWMF_INVALID_DECREMENT_ACTIVITY bad message reason (Closed)

Created:
4 years, 2 months ago by falken
Modified:
4 years, 2 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

histograms: Add ESWMF_INVALID_DECREMENT_ACTIVITY bad message reason Generated by tools/metrics/histograms/update_bad_message_reasons.py This reason was added in https://crrev.com/4c82177a8b45303c941ddbc469444f0bfc760de4 Also fix typo. BUG=602442 Committed: https://crrev.com/b5852fe41e3919a32a7c33e87bbad4ad215b6c17 Cr-Commit-Position: refs/heads/master@{#426554}

Patch Set 1 #

Patch Set 2 : also fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M extensions/browser/bad_message.h View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_service_worker_message_filter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
falken
asvitkine: PTAL and hit CQ if it's ok
4 years, 2 months ago (2016-10-20 07:05:04 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 2 months ago (2016-10-20 15:01:15 UTC) #5
lazyboy
lgtm lgtm Sorry, I had that change in histograms.xml at some point, but got dropped ...
4 years, 2 months ago (2016-10-20 17:29:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429283004/20001
4 years, 2 months ago (2016-10-20 17:29:39 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 19:04:40 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:21:02 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b5852fe41e3919a32a7c33e87bbad4ad215b6c17
Cr-Commit-Position: refs/heads/master@{#426554}

Powered by Google App Engine
This is Rietveld 408576698