Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2429203003: Limit Mojo messages recursion depth in Java (Closed)

Created:
4 years, 2 months ago by tibell
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, agrieve+watch_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Limit Mojo messages recursion depth in Java BUG=640298 Committed: https://crrev.com/4136c0787271051cc2ce39071eeea98a223479c3 Cr-Commit-Position: refs/heads/master@{#426406}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -105 lines) Patch
M mojo/android/javatests/src/org/chromium/mojo/bindings/ValidationTest.java View 1 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java View 4 chunks +29 lines, -0 lines 0 comments Download
M mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl View 14 chunks +107 lines, -101 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
tibell
Since we can reuse the conformance tests I've already written for C++ this looks like ...
4 years, 2 months ago (2016-10-19 03:34:31 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 2 months ago (2016-10-19 05:56:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429203003/1
4 years, 2 months ago (2016-10-20 03:05:01 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/285706)
4 years, 2 months ago (2016-10-20 03:32:58 UTC) #16
tibell
Rebase
4 years, 2 months ago (2016-10-20 03:40:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2429203003/20001
4 years, 2 months ago (2016-10-20 03:42:03 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-20 04:46:34 UTC) #21
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:15:44 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4136c0787271051cc2ce39071eeea98a223479c3
Cr-Commit-Position: refs/heads/master@{#426406}

Powered by Google App Engine
This is Rietveld 408576698