Allow webkitSpeechRecognition work from an app's background page.

chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/speech/chrome_speech_recognition_manager_delegate.h"
 
 #include <set>
 #include <string>
 
 #include "base/bind.h"
@@ skipping 391 matching lines @@
   WebContents* web_contents = WebContents::FromRenderViewHost(render_view_host);
   extensions::ViewType view_type = extensions::GetViewType(web_contents);
 
   // TODO(kalman): Also enable speech bubble for extension popups
   // (VIEW_TYPE_EXTENSION_POPUP) once popup-like control UI works properly in
   // extensions: http://crbug.com/163851.
   // Right now the extension popup closes and dismisses immediately on user
   // click.
   if (view_type == extensions::VIEW_TYPE_TAB_CONTENTS ||
       view_type == extensions::VIEW_TYPE_APP_SHELL ||
-      view_type == extensions::VIEW_TYPE_VIRTUAL_KEYBOARD) {
+      view_type == extensions::VIEW_TYPE_VIRTUAL_KEYBOARD ||
+      // Only allow requests through JavaScript API (|js_api| = true).
+      // Requests originating from html element (|js_api| = false) would want
+      // to show bubble which isn't quite intuitive from a background page. Also
+      // see todo above about issues with rendering such bubbles from extension
+      // popups.
+      (view_type == extensions::VIEW_TYPE_EXTENSION_BACKGROUND_PAGE &&
+           js_api)) {
     // If it is a tab, we can show the speech input bubble or ask for
     // permission.
 
     allowed = true;
     if (js_api)
       ask_permission = true;

[not at google - send to devlin, 2013/09/20 22:36:46]

do you know how this ask_permission thing is supposed to work? comments imply
otherwise.

[lazyboy, 2013/09/20 22:49:08]

The |callback| carries |ask_permission|, which eventually checks the manifest
for apps:

The callback here corresponds to
SpeechRecognitionManagerImpl::RecognitionAllowedCallback(), with
ask_permission/ask_user set to true, requests for MEDIA_DEVICE_AUDIO_CAPTURE:
for regular page, that would show infobar, and for the apps case, it would check
the manifest for "audioCapture".

The comment here about tab is quite stale, we need to fix that.

[not at google - send to devlin, 2013/09/20 23:03:41]

Yeah; "check_permission" would be better. "ask_permission" is confusing and as
you say the comment is out of date. Could you update it now?

[lazyboy, 2013/09/21 00:48:04]

Done.

   }
 
   BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
                           base::Bind(callback, ask_permission, allowed));
 }
 
 }  // namespace speech