third_party/WebKit/LayoutTests/fast/block/positioning/fixed-in-abs-height-change.html - Issue 2429113002: Don't update height in LayoutBlock::markFixedPositionObjectForLayoutIfNeeded.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/block/positioning/fixed-in-abs-height-change.html

Issue 2429113002: Don't update height in LayoutBlock::markFixedPositionObjectForLayoutIfNeeded. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <style>

	5

	6 .fixed {

	7 left: 100px;

	8 width: 600px;

	9 height: 25%;

	10 position: fixed;

	11 }

	12 .box {

	13 position: absolute;

	14 bottom: 0;

	15 width: 600px;

	16 height: 100px;

	17 background: lightblue;

	18 }

	19

	20 </style>

	21 <div style="position: absolute">

	22 <div class="fixed">

	23 <div class="box"></div>

	24 </div>

	25 </div>

	26 <script>

	27

	28 test(() => {

	29 // Force initial layout.

	30 document.body.offsetHeight;

	31

	32 var fixed = document.querySelector(".fixed");

	33 var box = document.querySelector(".box");

	34 fixed.style.height = "75%";

	35

	36 assert_equals(box.offsetTop, 350);
	mstensho (USE GERRIT) 2016/10/19 18:24:30 This value depends on the viewport height, which i This value depends on the viewport height, which is not so great for testing, in general. Do you really need to use percentages on the fixedpos? Seems to me it's just as broken if you used px values (without your fix, that is). skobes 2016/10/19 21:48:40 Good point, done. Show quoted text On 2016/10/19 18:24:30, mstensho wrote: > This value depends on the viewport height, which is not so great for testing, in > general. Do you really need to use percentages on the fixedpos? Seems to me it's > just as broken if you used px values (without your fix, that is). Good point, done.
	37 }, "Fixed-pos in abs-pos container updates children on height change.");

	38

	39 </script>

OLD	NEW