Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: chrome/browser/chromeos/login/ui/webui_login_view.h

Issue 2429033003: cros: Cleanup lock screen and OOBE C++ backing code. (Closed)
Patch Set: Address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/ui/webui_login_view.h
diff --git a/chrome/browser/chromeos/login/ui/webui_login_view.h b/chrome/browser/chromeos/login/ui/webui_login_view.h
index 5963cf379b356591e5fe50c8b1464e45e7ea2197..5fbd2c7b2e62852ac114824ed3307ddcf2bc9b0d 100644
--- a/chrome/browser/chromeos/login/ui/webui_login_view.h
+++ b/chrome/browser/chromeos/login/ui/webui_login_view.h
@@ -33,6 +33,8 @@ class Widget;
namespace chromeos {
+class OobeUI;
+
// View used to render a WebUI supporting Widget. This widget is used for the
// WebUI based start up and lock screens. It contains a WebView.
class WebUILoginView : public views::View,
@@ -78,6 +80,9 @@ class WebUILoginView : public views::View,
// Returns current WebContents.
content::WebContents* GetWebContents();
+ // Returns instance of the OOBE WebUI.
+ OobeUI* GetOobeUI();
+
// Opens proxy settings dialog.
void OpenProxySettings();
@@ -112,7 +117,7 @@ class WebUILoginView : public views::View,
const content::NotificationDetails& details) override;
// WebView for rendering a webpage as a webui login.
- views::WebView* webui_login_;
+ views::WebView* webui_login_ = nullptr;
private:
// Map type for the accelerator-to-identifier map.
@@ -150,17 +155,17 @@ class WebUILoginView : public views::View,
AccelMap accel_map_;
// True when WebUI is being initialized hidden.
- bool is_hidden_;
+ bool is_hidden_ = false;
// True when the WebUI has finished initializing and is visible.
- bool webui_visible_;
+ bool webui_visible_ = false;
// Should we emit the login-prompt-visible signal when the login page is
// displayed?
- bool should_emit_login_prompt_visible_;
+ bool should_emit_login_prompt_visible_ = true;
// True to forward keyboard event.
- bool forward_keyboard_event_;
+ bool forward_keyboard_event_ = true;
// A FocusTraversable for StatusAreaWidget that uses
// |status_area_widget_host_| as placeholder in WebUiLoginView's focus chain.
« no previous file with comments | « chrome/browser/chromeos/login/ui/login_display_host_impl.cc ('k') | chrome/browser/chromeos/login/ui/webui_login_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698