cros: Cleanup lock screen and OOBE C++ backing code.

cros: Cleanup lock screen and OOBE C++ backing code.

There are no functional changes in this CL.

This CL removes the ScreenLockerDelegate class; WebUIScreenLocker is used directly instead. The ScreenLockerDelegate abstraction was used for porting purposes and is no longer needed.

The LockWindow::Delegate class was removed as it is also no longer needed. This simplifies the interaction between LockWindow and WebUIScreenLocker.

This CL also removes a large number of static_cast<OobeUI*> calls by pulling them into common methods.

BUG=452599
Committed: https://crrev.com/55c7b0b7f156c57ff2b421c1347c05d07ef8ba18
Cr-Commit-Position: refs/heads/master@{#426645}

[jdufault, 2016-10-18 22:39:02]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 22:39:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 00:26:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 00:26:59]

Dry run: This issue passed the CQ dry run.

[jdufault, 2016-10-19 22:14:27]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 22:15:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2016-10-19 23:31:58]

Patchset #1 (id:1) has been deleted

[jdufault, 2016-10-19 23:33:02]

Description was changed from

==========
cros: Cleanup WebUIScreenLocker usage.

This CL removes the ScreenLockerDelegate class, instead opting to directly use
the WebUIScreenLocker class.

BUG=452599
==========

to

==========
cros: Cleanup WebUIScreenLocker usage.

This CL removes the ScreenLockerDelegate class, instead opting to directly use
the WebUIScreenLocker class.

BUG=452599
==========

[jdufault, 2016-10-19 23:33:03]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org

[jdufault, 2016-10-19 23:33:25]

achuith@ PTAL. This CL removes some abstraction which is no longer needed.

[commit-bot: I haz the power, 2016-10-19 23:51:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 23:51:24]

Dry run: This issue passed the CQ dry run.

[achuithb, 2016-10-20 17:38:33]

Is there any change of behavior with this CL?

https://codereview.chromium.org/2429033003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/lock/screen_locker.h (right):

https://codereview.chromium.org/2429033003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/lock/screen_locker.h:96: WebUIScreenLocker*
web_ui() const { return web_ui_.get(); }
Wonder if we should drop the const here since we end up doing all kinds of
non-const operations with the raw pointer.

https://codereview.chromium.org/2429033003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/lock/webui_screen_locker.h (right):

https://codereview.chromium.org/2429033003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/lock/webui_screen_locker.h:62: // Initialize the
screen locker delegate. This will call ScreenLockReady when
What screen locker delegate?

https://codereview.chromium.org/2429033003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/lock/webui_screen_locker.h:159: // ScreenLocker
that owns this delegate.
let's not use the word delegate here.

https://codereview.chromium.org/2429033003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/lock/webui_screen_locker.h:160: ScreenLocker*
screen_locker_;
let's do = nullptr for consistency.

https://codereview.chromium.org/2429033003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h (right):

https://codereview.chromium.org/2429033003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h:182: OobeUI*
oobe_ui_;
= nullptr

[jdufault, 2016-10-20 19:31:38]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-20 19:32:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2016-10-20 19:35:19]

> Is there any change of behavior with this CL?

Nope, just lots of cleanup.

I've also removed some static_casts in the updated CL.

https://codereview.chromium.org/2429033003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/lock/screen_locker.h (right):

https://codereview.chromium.org/2429033003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/lock/screen_locker.h:96: WebUIScreenLocker*
web_ui() const { return web_ui_.get(); }
On 2016/10/20 17:38:33, achuithb wrote:
> Wonder if we should drop the const here since we end up doing all kinds of
> non-const operations with the raw pointer.

I've dropped the const and made the preferred usage web_ui().

https://codereview.chromium.org/2429033003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/lock/webui_screen_locker.h (right):

https://codereview.chromium.org/2429033003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/lock/webui_screen_locker.h:62: // Initialize the
screen locker delegate. This will call ScreenLockReady when
On 2016/10/20 17:38:33, achuithb wrote:
> What screen locker delegate?

These comments were copied from screen_locker_delegate.h. I've cleaned some of
them up.

https://codereview.chromium.org/2429033003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/lock/webui_screen_locker.h:159: // ScreenLocker
that owns this delegate.
On 2016/10/20 17:38:33, achuithb wrote:
> let's not use the word delegate here.

Done.

https://codereview.chromium.org/2429033003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/lock/webui_screen_locker.h:160: ScreenLocker*
screen_locker_;
On 2016/10/20 17:38:33, achuithb wrote:
> let's do = nullptr for consistency.

Done.

https://codereview.chromium.org/2429033003/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h (right):

https://codereview.chromium.org/2429033003/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h:182: OobeUI*
oobe_ui_;
On 2016/10/20 17:38:33, achuithb wrote:
> = nullptr

Done.

[achuithb, 2016-10-20 19:41:39]

Are the changes to accessibility_extension_loader.cc from a rebase? There are a
few other changes that seem unrelated.

Could you please expand the commit message with more details about the changes
in this CL?

lgtm otherwise.

[jdufault, 2016-10-20 19:44:10]

On 2016/10/20 19:41:39, achuithb wrote:
> Are the changes to accessibility_extension_loader.cc from a rebase? There are
a
> few other changes that seem unrelated.

There is a real change to that file, but there was also a rebase in-between
patch-sets. Sorry about that.

> Could you please expand the commit message with more details about the changes
> in this CL?
> 
> lgtm otherwise.

Will do, thanks.

[jdufault, 2016-10-20 19:48:15]

Description was changed from

==========
cros: Cleanup WebUIScreenLocker usage.

This CL removes the ScreenLockerDelegate class, instead opting to directly use
the WebUIScreenLocker class.

BUG=452599
==========

to

==========
cros: Cleanup lock screen and OOBE C++ backing code.

This CL removes the ScreenLockerDelegate class, which is no longer needed.
Instead, WebUIScreenLocker is used directly.

The LockWindow::Delegate class was removed as it is no longer needed. This
simplifies the interaction between LockWindow and WebUIScreenLocker.

This CL also removes a large number of static_cast<OobeUI*> calls by pulling
them into common methods.

BUG=452599
==========

[jdufault, 2016-10-20 19:48:27]

Description was changed from

==========
cros: Cleanup lock screen and OOBE C++ backing code.

This CL removes the ScreenLockerDelegate class, which is no longer needed.
Instead, WebUIScreenLocker is used directly.

The LockWindow::Delegate class was removed as it is no longer needed. This
simplifies the interaction between LockWindow and WebUIScreenLocker.

This CL also removes a large number of static_cast<OobeUI*> calls by pulling
them into common methods.

BUG=452599
==========

to

==========
cros: Cleanup lock screen and OOBE C++ backing code.

This CL has no functional changes.

This CL removes the ScreenLockerDelegate class, which is no longer needed.
Instead, WebUIScreenLocker is used directly.

The LockWindow::Delegate class was removed as it is no longer needed. This
simplifies the interaction between LockWindow and WebUIScreenLocker.

This CL also removes a large number of static_cast<OobeUI*> calls by pulling
them into common methods.

BUG=452599
==========

[jdufault, 2016-10-20 19:50:43]

Description was changed from

==========
cros: Cleanup lock screen and OOBE C++ backing code.

This CL has no functional changes.

This CL removes the ScreenLockerDelegate class, which is no longer needed.
Instead, WebUIScreenLocker is used directly.

The LockWindow::Delegate class was removed as it is no longer needed. This
simplifies the interaction between LockWindow and WebUIScreenLocker.

This CL also removes a large number of static_cast<OobeUI*> calls by pulling
them into common methods.

BUG=452599
==========

to

==========
cros: Cleanup lock screen and OOBE C++ backing code.

There are no functional changes in this CL.

This CL removes the ScreenLockerDelegate class; WebUIScreenLocker is used
directly instead. The ScreenLockerDelegate abstraction was used for porting
purposes and is no longer needed.

The LockWindow::Delegate class was removed as it is also no longer needed. This
simplifies the interaction between LockWindow and WebUIScreenLocker.

This CL also removes a large number of static_cast<OobeUI*> calls by pulling
them into common methods.

BUG=452599
==========

[jdufault, 2016-10-20 19:50:58]

The CQ bit was unchecked by jdufault@chromium.org

[jdufault, 2016-10-20 19:50:58]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2016-10-20 19:51:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 21:16:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-20 21:16:16]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jdufault1, 2016-10-20 21:18:56]

The CQ bit was checked by jdufault@google.com

[commit-bot: I haz the power, 2016-10-20 21:19:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-20 23:25:59]

Description was changed from

==========
cros: Cleanup lock screen and OOBE C++ backing code.

There are no functional changes in this CL.

This CL removes the ScreenLockerDelegate class; WebUIScreenLocker is used
directly instead. The ScreenLockerDelegate abstraction was used for porting
purposes and is no longer needed.

The LockWindow::Delegate class was removed as it is also no longer needed. This
simplifies the interaction between LockWindow and WebUIScreenLocker.

This CL also removes a large number of static_cast<OobeUI*> calls by pulling
them into common methods.

BUG=452599
==========

to

==========
cros: Cleanup lock screen and OOBE C++ backing code.

There are no functional changes in this CL.

This CL removes the ScreenLockerDelegate class; WebUIScreenLocker is used
directly instead. The ScreenLockerDelegate abstraction was used for porting
purposes and is no longer needed.

The LockWindow::Delegate class was removed as it is also no longer needed. This
simplifies the interaction between LockWindow and WebUIScreenLocker.

This CL also removes a large number of static_cast<OobeUI*> calls by pulling
them into common methods.

BUG=452599
==========

[commit-bot: I haz the power, 2016-10-20 23:26:10]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:24:29]

Description was changed from

==========
cros: Cleanup lock screen and OOBE C++ backing code.

There are no functional changes in this CL.

This CL removes the ScreenLockerDelegate class; WebUIScreenLocker is used
directly instead. The ScreenLockerDelegate abstraction was used for porting
purposes and is no longer needed.

The LockWindow::Delegate class was removed as it is also no longer needed. This
simplifies the interaction between LockWindow and WebUIScreenLocker.

This CL also removes a large number of static_cast<OobeUI*> calls by pulling
them into common methods.

BUG=452599
==========

to

==========
cros: Cleanup lock screen and OOBE C++ backing code.

There are no functional changes in this CL.

This CL removes the ScreenLockerDelegate class; WebUIScreenLocker is used
directly instead. The ScreenLockerDelegate abstraction was used for porting
purposes and is no longer needed.

The LockWindow::Delegate class was removed as it is also no longer needed. This
simplifies the interaction between LockWindow and WebUIScreenLocker.

This CL also removes a large number of static_cast<OobeUI*> calls by pulling
them into common methods.

BUG=452599

Committed: https://crrev.com/55c7b0b7f156c57ff2b421c1347c05d07ef8ba18
Cr-Commit-Position: refs/heads/master@{#426645}
==========

[commit-bot: I haz the power, 2016-10-21 13:24:30]

Patchset 2 (id:??) landed as
https://crrev.com/55c7b0b7f156c57ff2b421c1347c05d07ef8ba18
Cr-Commit-Position: refs/heads/master@{#426645}