Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: chrome/browser/about_flags.cc

Issue 2428873002: Add about_flag for experimenting MediaSession on Desktop (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index b2ee923f355a8a37c065e1621ecd82fe6492aa9f..514097b2c721b487527eb49cce4f1adeb72b9215 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -600,6 +600,17 @@ const FeatureEntry::Choice kSecurityChipAnimationChoices[] = {
switches::kSecurityChipAnimationAll},
};
+const FeatureEntry::Choice kEnableDefaultMediaSessionChoices[] = {
+ {IDS_FLAGS_ENABLE_DEFAULT_MEDIA_SESSION_DISABLED, "", ""},
+ {IDS_FLAGS_ENABLE_DEFAULT_MEDIA_SESSION_ENABLED,
+ switches::kEnableDefaultMediaSession, ""},
+#if defined(ENABLE_PLUGINS)
+ {IDS_FLAGS_ENABLE_DEFAULT_MEDIA_SESSION_ENABLED_WITH_FLASH,
+ switches::kEnableDefaultMediaSession,
+ switches::kEnableDefaultMediaSessionWithFlash},
+#endif // defined(ENABLE_PLUGINS)
+};
+
// RECORDING USER METRICS FOR FLAGS:
// -----------------------------------------------------------------------------
// The first line of the entry is the internal name.
@@ -2029,12 +2040,16 @@ const FeatureEntry kFeatureEntries[] = {
IDS_FLAGS_EXPENSIVE_BACKGROUND_TIMER_THROTTLING_NAME,
IDS_FLAGS_EXPENSIVE_BACKGROUND_TIMER_THROTTLING_DESCRIPTION, kOsAll,
FEATURE_VALUE_TYPE(features::kExpensiveBackgroundTimerThrottling)},
- {"security-chip", IDS_FLAGS_SECURITY_CHIP_NAME,
+ {"security-chip", IDS_FLAGS_SECURITY_CHIP_NAME,
IDS_FLAGS_SECURITY_CHIP_DESCRIPTION, kOsDesktop,
MULTI_VALUE_TYPE(kSecurityChipChoices)},
{"security-chip-animation", IDS_FLAGS_SECURITY_CHIP_ANIMATION_NAME,
IDS_FLAGS_SECURITY_CHIP_ANIMATION_DESCRIPTION, kOsDesktop,
MULTI_VALUE_TYPE(kSecurityChipAnimationChoices)},
+ {"enable-default-media-session",
+ IDS_FLAGS_ENABLE_DEFAULT_MEDIA_SESSION_NAME,
+ IDS_FLAGS_ENABLE_DEFAULT_MEDIA_SESSION_DESCRIPTION, kOsDesktop,
+ MULTI_VALUE_TYPE(kEnableDefaultMediaSessionChoices)},
// NOTE: Adding new command-line switches requires adding corresponding
// entries to enum "LoginCustomFlags" in histograms.xml. See note in
// histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.

Powered by Google App Engine
This is Rietveld 408576698