Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: components/metrics/metrics_log.h

Issue 2428413005: Revise system profile prefs clearing (Closed)
Patch Set: Update LoadSavedEnvironmentFromPrefs's comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/metrics/metrics_log.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_log.h
diff --git a/components/metrics/metrics_log.h b/components/metrics/metrics_log.h
index 6b37e7b4c9805ae535c014939703e965a791f397..c111fb3380621dc7e96c8e8c3693a0bd362134f5 100644
--- a/components/metrics/metrics_log.h
+++ b/components/metrics/metrics_log.h
@@ -87,12 +87,10 @@ class MetricsLog {
const base::HistogramSamples& snapshot);
// Records the current operating environment, including metrics provided by
- // the specified set of |metrics_providers|. Takes the list of installed
- // plugins, Google Update statistics, and synthetic trial IDs as parameters
- // because those can't be obtained synchronously from the UI thread.
- // A synthetic trial is one that is set up dynamically by code in Chrome. For
- // example, a pref may be mapped to a synthetic trial such that the group
- // is determined by the pref value.
+ // the specified set of |metrics_providers|. Takes the list of synthetic
+ // trial IDs as a parameter. A synthetic trial is one that is set up
+ // dynamically by code in Chrome. For example, a pref may be mapped to a
+ // synthetic trial such that the group is determined by the pref value.
void RecordEnvironment(
const std::vector<MetricsProvider*>& metrics_providers,
const std::vector<variations::ActiveGroupId>& synthetic_trials,
@@ -100,10 +98,9 @@ class MetricsLog {
int64_t metrics_reporting_enabled_date);
// Loads the environment proto that was saved by the last RecordEnvironment()
- // call from prefs and clears the pref value. On success, returns true and
- // |app_version| contains the recovered version. Otherwise (if there was no
- // saved environment in prefs or it could not be decoded), returns false and
- // |app_version| is empty.
+ // call from prefs. On success, returns true and |app_version| contains the
+ // recovered version. Otherwise (if there was no saved environment in prefs
+ // or it could not be decoded), returns false and |app_version| is empty.
bool LoadSavedEnvironmentFromPrefs(std::string* app_version);
// Writes application stability metrics, including stability metrics provided
« no previous file with comments | « no previous file | components/metrics/metrics_log.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698