Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2428413004: Revert "[compiler] Ship Ignition for all TurboFan code." (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert "[compiler] Ship Ignition for all TurboFan code." Breaks layout tests on Blink builders. TBR=machenbach@chromium.org Committed: https://crrev.com/510b56d3f2c57809dd14951533ce0b57c75b1eb8 Cr-Commit-Position: refs/heads/master@{#40471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -91 lines) Patch
M src/api.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 5 chunks +35 lines, -35 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M src/d8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/frames.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/isolate.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/log.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 3 chunks +13 lines, -23 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 3 chunks +8 lines, -5 lines 0 comments Download
M test/mjsunit/wasm/compiled-module-management.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
Michael Starzinger
4 years, 2 months ago (2016-10-20 13:00:27 UTC) #3
Michael Achenbach
lgtm
4 years, 2 months ago (2016-10-20 13:09:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428413004/1
4 years, 2 months ago (2016-10-20 13:37:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/26960)
4 years, 2 months ago (2016-10-20 13:51:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428413004/1
4 years, 2 months ago (2016-10-20 13:59:40 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 14:08:56 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:08:15 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/510b56d3f2c57809dd14951533ce0b57c75b1eb8
Cr-Commit-Position: refs/heads/master@{#40471}

Powered by Google App Engine
This is Rietveld 408576698