Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2428383005: Remove switch kEnableWebRtcHWH264Encoding (Closed)

Created:
4 years, 2 months ago by braveyao
Modified:
4 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, nasko+codewatch_chromium.org, achuith+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove switch kEnableWebRtcHWH264Encoding switches::kEnableWebRtcHWH264Encoding was added for extensions and can be used before SW fallback is in place. Now it's time to remove it since SW fallback is already ready for all desktop platforms. BTW: Another reason is after cl https://codereview.chromium.org/2358683002/ has landed, the checking to switches::kDisableWebRtcHWEncoding is having the same effect. BUG=651981 Committed: https://crrev.com/58e2e63439209a92a85c0aca328f68d3abab9af2 Cr-Commit-Position: refs/heads/master@{#426820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/chrome_content_browser_client_extensions_part.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/media/gpu/rtc_video_encoder_factory.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
braveyao
Hi Jam@, please take a look!
4 years, 2 months ago (2016-10-20 18:32:55 UTC) #4
jam
lgtm
4 years, 2 months ago (2016-10-21 15:52:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428383005/1
4 years, 2 months ago (2016-10-21 16:39:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 16:57:48 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 17:06:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58e2e63439209a92a85c0aca328f68d3abab9af2
Cr-Commit-Position: refs/heads/master@{#426820}

Powered by Google App Engine
This is Rietveld 408576698