Make Document::m_IconList a vector of IconElements. (try 2)

Make Document::m_IconList a vector of IconElements. (try 2)

It does not need to be a std::list. This time keep the elements as
unique_ptrs.

Previous attempt: https://codereview.chromium.org/2428743004/

Committed: https://pdfium.googlesource.com/pdfium/+/dadea5f87d35f8a692b659dbff54cc8780d48ef8

[Lei Zhang, 2016-10-19 19:38:51]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org, npm@chromium.org

[Lei Zhang, 2016-10-19 19:38:51]

I didn't bother re-uploading the previous reverted CL.

[Lei Zhang, 2016-10-19 19:38:59]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 19:39:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-10-19 19:40:15]

What was the fix?

[commit-bot: I haz the power, 2016-10-19 19:55:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 19:55:52]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-10-19 20:26:18]

On 2016/10/19 19:40:15, dsinclair wrote:
> What was the fix?

"This time keep the elements as unique_ptrs."

[dsinclair, 2016-10-19 20:29:29]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-10-19 20:29:29]

lgtm

[commit-bot: I haz the power, 2016-10-19 20:29:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 20:29:50]

Description was changed from

==========
Make Document::m_IconList a vector of IconElements. (try 2)

It does not need to be a std::list. This time keep the elements as
unique_ptrs.

Previous attempt: https://codereview.chromium.org/2428743004/
==========

to

==========
Make Document::m_IconList a vector of IconElements. (try 2)

It does not need to be a std::list. This time keep the elements as
unique_ptrs.

Previous attempt: https://codereview.chromium.org/2428743004/

Committed:
https://pdfium.googlesource.com/pdfium/+/dadea5f87d35f8a692b659dbff54cc8780d4...
==========

[commit-bot: I haz the power, 2016-10-19 20:29:51]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/dadea5f87d35f8a692b659dbff54cc8780d4...