Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/input/EventHandlerTest.cpp

Issue 2428363004: Get rid of createVisibleSelection() taking PositionWithAffinity (Closed)
Patch Set: 2016-10-20T14:00:21 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp ('k') | third_party/WebKit/Source/core/page/DragController.cpp » ('j') | third_party/WebKit/Source/core/page/DragController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/input/EventHandlerTest.cpp
diff --git a/third_party/WebKit/Source/core/input/EventHandlerTest.cpp b/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
index d1ec45a7f6382c6a7bfd52d9896a6379d6c7fed6..19b58c2077427c5d2344963b553f22223c5f278b 100644
--- a/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
+++ b/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
@@ -245,7 +245,9 @@ TEST_F(EventHandlerTest, sendContextMenuEventWithHover) {
document().body()->appendChild(script);
document().updateStyleAndLayout();
document().frame()->selection().setSelection(
- createVisibleSelection(Position(document().body(), 0)));
+ SelectionInDOMTree::Builder()
+ .collapse(Position(document().body(), 0))
+ .build());
PlatformMouseEvent mouseDownEvent(
IntPoint(0, 0), IntPoint(100, 200), WebPointerProperties::Button::Right,
PlatformEvent::MousePressed, 1, PlatformEvent::Modifiers::RightButtonDown,
« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp ('k') | third_party/WebKit/Source/core/page/DragController.cpp » ('j') | third_party/WebKit/Source/core/page/DragController.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698