Get rid of createVisibleSelection() taking PositionWithAffinity

third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

 /*
  * Copyright (C) 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1626 matching lines @@
       return;
   }
 
   // TextIterator::rangeLength requires clean layout.
   document().updateStyleAndLayoutIgnorePendingStylesheets();
 
   destinationIndex = TextIterator::rangeLength(
       Position::firstPositionInNode(document().documentElement()),
       destination.toParentAnchoredPosition(), true);
 
-  VisibleSelection destinationSelection = createVisibleSelection(
-      destination.toPositionWithAffinity(), originalIsDirectional);
+  VisibleSelection destinationSelection =
+      createVisibleSelection(SelectionInDOMTree::Builder()
+                                 .collapse(destination.toPositionWithAffinity())
+                                 .setIsDirectional(originalIsDirectional)
+                                 .build());
   if (endingSelection().isNone()) {
     // We abort executing command since |destination| becomes invisible.
     editingState->abort();
     return;
   }
   setEndingSelection(destinationSelection);
   ReplaceSelectionCommand::CommandOptions options =
       ReplaceSelectionCommand::SelectReplacement |
       ReplaceSelectionCommand::MovingParagraph;
   if (shouldPreserveStyle == DoNotPreserveStyle)
@@ skipping 203 matching lines @@
   VisiblePosition atBR = VisiblePosition::beforeNode(br);
   // If the br we inserted collapsed, for example:
   //   foo<br><blockquote>...</blockquote>
   // insert a second one.
   if (!isStartOfParagraph(atBR)) {
     insertNodeBefore(HTMLBRElement::create(document()), br, editingState);
     if (editingState->isAborted())
       return false;
     document().updateStyleAndLayoutIgnorePendingStylesheets();
   }
-  setEndingSelection(createVisibleSelection(atBR.toPositionWithAffinity(),
-                                            endingSelection().isDirectional()));
+  setEndingSelection(createVisibleSelection(
+      SelectionInDOMTree::Builder()
+          .collapse(atBR.toPositionWithAffinity())
+          .setIsDirectional(endingSelection().isDirectional())
+          .build()));
 
   // If this is an empty paragraph there must be a line break here.
   if (!lineBreakExistsAtVisiblePosition(caret))
     return false;
 
   Position caretPos(mostForwardCaretPosition(caret.deepEquivalent()));
   // A line break is either a br or a preserved newline.
   DCHECK(isHTMLBRElement(caretPos.anchorNode()) ||
          (caretPos.anchorNode()->isTextNode() &&
           caretPos.anchorNode()->layoutObject()->style()->preserveNewline()))
@@ skipping 133 matching lines @@
   return node;
 }
 
 DEFINE_TRACE(CompositeEditCommand) {
   visitor->trace(m_commands);
   visitor->trace(m_composition);
   EditCommand::trace(visitor);
 }
 
 }  // namespace blink