third_party/WebKit/Source/core/editing/VisibleSelection.h - Issue 2428363004: Get rid of createVisibleSelection() taking PositionWithAffinity

Side by Side Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2428363004: Get rid of createVisibleSelection() taking PositionWithAffinity (Closed)

Patch Set: 2016-10-20T14:00:21 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/Source/core/editing/DOMSelection.cpp ('k') | third_party/WebKit/Source/core/editing/VisibleSelection.cpp » ('j') | third_party/WebKit/Source/core/page/DragController.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.	2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 211 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
222 const Position& extent,	222 const Position& extent,

223 TextAffinity = SelDefaultAffinity,	223 TextAffinity = SelDefaultAffinity,

224 bool isDirectional = false);	224 bool isDirectional = false);

225 CORE_EXPORT VisibleSelection	225 CORE_EXPORT VisibleSelection

226 createVisibleSelection(const EphemeralRange&,	226 createVisibleSelection(const EphemeralRange&,

227 TextAffinity = SelDefaultAffinity,	227 TextAffinity = SelDefaultAffinity,

228 bool isDirectional = false);	228 bool isDirectional = false);

229 CORE_EXPORT VisibleSelection createVisibleSelection(const VisiblePosition&,	229 CORE_EXPORT VisibleSelection createVisibleSelection(const VisiblePosition&,

230 const VisiblePosition&,	230 const VisiblePosition&,

231 bool isDirectional = false);	231 bool isDirectional = false);

232 CORE_EXPORT VisibleSelection createVisibleSelection(const PositionWithAffinity&,

233 bool isDirectional = false);

234	232

235 CORE_EXPORT VisibleSelectionInFlatTree	233 CORE_EXPORT VisibleSelectionInFlatTree

236 createVisibleSelection(const SelectionInFlatTree&);	234 createVisibleSelection(const SelectionInFlatTree&);

237 CORE_EXPORT VisibleSelectionInFlatTree	235 CORE_EXPORT VisibleSelectionInFlatTree

238 createVisibleSelection(const PositionInFlatTree& base,	236 createVisibleSelection(const PositionInFlatTree& base,

239 const PositionInFlatTree& extent,	237 const PositionInFlatTree& extent,

240 TextAffinity = SelDefaultAffinity,	238 TextAffinity = SelDefaultAffinity,

241 bool isDirectional = false);	239 bool isDirectional = false);

242 CORE_EXPORT VisibleSelectionInFlatTree	240 CORE_EXPORT VisibleSelectionInFlatTree

243 createVisibleSelection(const VisiblePositionInFlatTree&,	241 createVisibleSelection(const VisiblePositionInFlatTree&,

(...skipping 15 matching lines...) Expand all Loading...
259	257

260 #ifndef NDEBUG	258 #ifndef NDEBUG

261 // Outside the WebCore namespace for ease of invocation from gdb.	259 // Outside the WebCore namespace for ease of invocation from gdb.

262 void showTree(const blink::VisibleSelection&);	260 void showTree(const blink::VisibleSelection&);

263 void showTree(const blink::VisibleSelection*);	261 void showTree(const blink::VisibleSelection*);

264 void showTree(const blink::VisibleSelectionInFlatTree&);	262 void showTree(const blink::VisibleSelectionInFlatTree&);

265 void showTree(const blink::VisibleSelectionInFlatTree*);	263 void showTree(const blink::VisibleSelectionInFlatTree*);

266 #endif	264 #endif

267	265

268 #endif // VisibleSelection_h	266 #endif // VisibleSelection_h

OLD	NEW