Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2428213002: [inspector] finish test runner gracefully.. (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman, chitsuhein
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] finish test runner gracefully.. .. to make windows bot happy. BUG=chromium:635948 R=dgozman@chromium.org Committed: https://crrev.com/ea511e769ed08336e9c12fcbd83b1f6132f2f358 Cr-Commit-Position: refs/heads/master@{#40415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
M test/inspector/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M test/inspector/debugger/stepping-with-blackboxed-ranges.js View 1 chunk +3 lines, -1 line 0 comments Download
M test/inspector/inspector-test.cc View 3 chunks +16 lines, -1 line 0 comments Download
M test/inspector/task-runner.h View 3 chunks +7 lines, -3 lines 0 comments Download
M test/inspector/task-runner.cc View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kozy
Dmitry, please take a look!
4 years, 2 months ago (2016-10-19 00:43:19 UTC) #1
dgozman
lgtm
4 years, 2 months ago (2016-10-19 01:14:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428213002/1
4 years, 2 months ago (2016-10-19 01:31:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 02:04:38 UTC) #5
chitsuhein
4 years, 2 months ago (2016-10-19 07:23:19 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:05:29 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea511e769ed08336e9c12fcbd83b1f6132f2f358
Cr-Commit-Position: refs/heads/master@{#40415}

Powered by Google App Engine
This is Rietveld 408576698