Refactor CallbackHelper to base/test

Refactor CallbackHelper and deps to base/test

TBR=danakj@chromium.org, tedchoc@chromium.org
BUG=657162
Committed: https://crrev.com/44c22c6fcaa63ad5ba558368523a73f212b32ffa
Cr-Commit-Position: refs/heads/master@{#426582}

[the real yoland, 2016-10-18 21:48:09]

yolandyan@chromium.org changed reviewers:
+ boliu@chromium.org, jbudorick@chromium.org, mikecase@chromium.org

[mikecase (-- gone --), 2016-10-18 21:57:43]

non-OWNER lgtm

[boliu, 2016-10-19 03:55:00]

https://codereview.chromium.org/2428163002/diff/1/base/test/android/javatests...
File
base/test/android/javatests/src/org/chromium/base/test/util/CallbackHelper.java
(right):

https://codereview.chromium.org/2428163002/diff/1/base/test/android/javatests...
base/test/android/javatests/src/org/chromium/base/test/util/CallbackHelper.java:207:
public void waitUntilCriteria(Criteria criteria, long timeout, TimeUnit unit)
I agree with jbudorick on the bug about *not* moving CriteriaHelper and related
things.

Looks like waitUntilCriteria is used by TestCallbackHelperContainer only. Can we
just rewrite that and remove this method? This is very close to polling which we
don't want in base.

[the real yoland, 2016-10-19 03:59:47]

On 2016/10/19 at 03:55:00, boliu wrote:
>
https://codereview.chromium.org/2428163002/diff/1/base/test/android/javatests...
> File
base/test/android/javatests/src/org/chromium/base/test/util/CallbackHelper.java
(right):
> 
>
https://codereview.chromium.org/2428163002/diff/1/base/test/android/javatests...
>
base/test/android/javatests/src/org/chromium/base/test/util/CallbackHelper.java:207:
public void waitUntilCriteria(Criteria criteria, long timeout, TimeUnit unit)
> I agree with jbudorick on the bug about *not* moving CriteriaHelper and
related things.
> 
> Looks like waitUntilCriteria is used by TestCallbackHelperContainer only. Can
we just rewrite that and remove this method? This is very close to polling which
we don't want in base.

Yes, this CL is removing waitUntilCriteria

[the real yoland, 2016-10-19 04:00:34]

On 2016/10/19 at 03:59:47, the real yoland wrote:
> On 2016/10/19 at 03:55:00, boliu wrote:
> >
https://codereview.chromium.org/2428163002/diff/1/base/test/android/javatests...
> > File
base/test/android/javatests/src/org/chromium/base/test/util/CallbackHelper.java
(right):
> > 
> >
https://codereview.chromium.org/2428163002/diff/1/base/test/android/javatests...
> >
base/test/android/javatests/src/org/chromium/base/test/util/CallbackHelper.java:207:
public void waitUntilCriteria(Criteria criteria, long timeout, TimeUnit unit)
> > I agree with jbudorick on the bug about *not* moving CriteriaHelper and
related things.
> > 
> > Looks like waitUntilCriteria is used by TestCallbackHelperContainer only.
Can we just rewrite that and remove this method? This is very close to polling
which we don't want in base.
> 
> Yes, this CL is removing waitUntilCriteria

Sorry this CL: https://codereview.chromium.org/2434473002

[the real yoland, 2016-10-19 21:27:43]

Will rebase after this CL lands:
https://codereview.chromium.org/2434473002

[the real yoland, 2016-10-20 04:40:20]

This CL is ready

[boliu, 2016-10-20 14:18:12]

lgtm

[the real yoland, 2016-10-20 18:52:05]

yolandyan@chromium.org changed reviewers:
+ danakj@chromium.org, tedchoc@chromium.org

[the real yoland, 2016-10-20 18:52:06]

Seeking owner lgtm:

+danakj: base/**
+tedchoc: chrome/**
+boliu: android_webview/**
        content/**

[boliu, 2016-10-20 18:58:13]

On 2016/10/20 18:52:06, the real yoland wrote:
> Seeking owner lgtm:
> 
> +danakj: base/**
> +tedchoc: chrome/**
> +boliu: android_webview/**
>         content/**

tbr is probably ok here

[boliu, 2016-10-20 18:58:53]

On 2016/10/20 18:58:13, boliu wrote:
> On 2016/10/20 18:52:06, the real yoland wrote:
> > Seeking owner lgtm:
> > 
> > +danakj: base/**
> > +tedchoc: chrome/**
> > +boliu: android_webview/**
> >         content/**
> 
> tbr is probably ok here

wait, no

get approval from base/test/android/OWNERS, then tbr the rest

[jbudorick, 2016-10-20 19:00:11]

On 2016/10/20 18:58:53, boliu wrote:
> On 2016/10/20 18:58:13, boliu wrote:
> > On 2016/10/20 18:52:06, the real yoland wrote:
> > > Seeking owner lgtm:
> > > 
> > > +danakj: base/**
> > > +tedchoc: chrome/**
> > > +boliu: android_webview/**
> > >         content/**
> > 
> > tbr is probably ok here
> 
> wait, no
> 
> get approval from base/test/android/OWNERS, then tbr the rest

base/test/android/ lgtm

[the real yoland, 2016-10-20 19:00:53]

On 2016/10/20 at 18:58:53, boliu wrote:
> On 2016/10/20 18:58:13, boliu wrote:
> > On 2016/10/20 18:52:06, the real yoland wrote:
> > > Seeking owner lgtm:
> > > 
> > > +danakj: base/**
> > > +tedchoc: chrome/**
> > > +boliu: android_webview/**
> > >         content/**
> > 
> > tbr is probably ok here
> 
> wait, no
> 
> get approval from base/test/android/OWNERS, then tbr the rest

+jbudorick : )

[the real yoland, 2016-10-20 19:03:10]

Description was changed from

==========
Refactor CallbackHelper and deps to base/test

BUG=657162
==========

to

==========
Refactor CallbackHelper and deps to base/test

TBR=danakj@chromium.org, tedchoc@chromium.org
BUG=657162
==========

[the real yoland, 2016-10-20 19:03:13]

The CQ bit was checked by yolandyan@chromium.org

[the real yoland, 2016-10-20 19:03:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2428163002/#ps80001
(title: "Change ui test gn")

[commit-bot: I haz the power, 2016-10-20 19:03:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2016-10-20 19:08:21]

On Thu, Oct 20, 2016 at 11:58 AM, <boliu@chromium.org> wrote:

> On 2016/10/20 18:58:13, boliu wrote:
> > On 2016/10/20 18:52:06, the real yoland wrote:
> > > Seeking owner lgtm:
> > >
> > > +danakj: base/**
> > > +tedchoc: chrome/**
> > > +boliu: android_webview/**
> > > content/**
> >
> > tbr is probably ok here
>
> wait, no
>
> get approval from base/test/android/OWNERS, then tbr the rest
>

+1 pls get a base/test/android owner.


>
> https://codereview.chromium.org/2428163002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jbudorick, 2016-10-20 19:34:34]

On 2016/10/20 19:08:21, danakj wrote:
> On Thu, Oct 20, 2016 at 11:58 AM, <mailto:boliu@chromium.org> wrote:
> 
> > On 2016/10/20 18:58:13, boliu wrote:
> > > On 2016/10/20 18:52:06, the real yoland wrote:
> > > > Seeking owner lgtm:
> > > >
> > > > +danakj: base/**
> > > > +tedchoc: chrome/**
> > > > +boliu: android_webview/**
> > > > content/**
> > >
> > > tbr is probably ok here
> >
> > wait, no
> >
> > get approval from base/test/android/OWNERS, then tbr the rest
> >
> 
> +1 pls get a base/test/android owner.

lgtmed above

> 
> 
> >
> > https://codereview.chromium.org/2428163002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2016-10-20 20:28:44]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-21 13:21:58]

Description was changed from

==========
Refactor CallbackHelper and deps to base/test

TBR=danakj@chromium.org, tedchoc@chromium.org
BUG=657162
==========

to

==========
Refactor CallbackHelper and deps to base/test

TBR=danakj@chromium.org, tedchoc@chromium.org
BUG=657162

Committed: https://crrev.com/44c22c6fcaa63ad5ba558368523a73f212b32ffa
Cr-Commit-Position: refs/heads/master@{#426582}
==========

[commit-bot: I haz the power, 2016-10-21 13:22:00]

Patchset 5 (id:??) landed as
https://crrev.com/44c22c6fcaa63ad5ba558368523a73f212b32ffa
Cr-Commit-Position: refs/heads/master@{#426582}