Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2428153002: Reland Turn on CompositeOpaqueFixedPosition for test and rebase tests. (patchset #7 id:120001 of ht… (Closed)

Created:
4 years, 2 months ago by flackr
Modified:
4 years, 2 months ago
Reviewers:
Stephen Chennney
CC:
blink-reviews, chromium-reviews, kinuko+watch, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland Turn on CompositeOpaqueFixedPosition for test and rebase tests. (patchset #7 id:120001 of https://codereview.chromium.org/2369603002/ ) TBR=schenney BUG=626200 Committed: https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec Cr-Commit-Position: refs/heads/master@{#426584}

Patch Set 1 #

Patch Set 2 : Mac rebaselines from rebaseline-cl #

Patch Set 3 : Manual mac baselines. #

Patch Set 4 : Merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-under-transform-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rtl/rtl-fixed-overflow-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/css3/filters/blur-filter-page-scroll-expected.png View 1 Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/css3/filters/blur-filter-page-scroll-parents-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/paint/deprecation/css-clip-and-clip-path.html View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/absolute-position-changed.html View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-with-abs-pos-child-scroll.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-scroll-in-empty-root-layer.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-scroll-in-empty-root-layer-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/filter-on-html-element-with-fixed-position-child.html View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed-child-move-after-scroll.html View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed-child-of-fixed-move-after-scroll.html View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed-move-after-scroll.html View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed-under-composited-absolute-scrolled.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/fixed-under-composited-fixed-scrolled.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/resources/repaint-with-scrollbar-change.html View 2 chunks +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/nested-render-surfaces-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/compositing/rtl/rtl-iframe-fixed-overflow-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/background-resize-height-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-child-move-after-scroll-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/fixed-move-after-scroll-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-child-move-after-scroll-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-move-after-scroll-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/fixed-under-composited-absolute-scrolled-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-render-surfaces-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/blur-filter-page-scroll-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/css3/filters/blur-filter-page-scroll-parents-expected.png View 1 2 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/filter-on-html-element-with-fixed-position-child-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-child-move-after-scroll-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-move-after-scroll-expected.png View 1 Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/fixed-under-composited-absolute-scrolled-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-render-surfaces-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/compositing/overflow/nested-render-surfaces-with-intervening-clip-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/blur-filter-page-scroll-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/css3/filters/blur-filter-page-scroll-parents-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win/paint/invalidation/background-resize-height-expected.txt View 9 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-child-move-after-scroll-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-child-of-fixed-move-after-scroll-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-move-after-scroll-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/fixed-under-composited-absolute-scrolled-expected.png View Binary file 0 comments Download
A + third_party/WebKit/LayoutTests/platform/win7/paint/invalidation/background-resize-height-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/data/fixed-position-losing-backing.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
flackr
Looks like I had to manually rebaseline the mac tests on a mac machine (for ...
4 years, 2 months ago (2016-10-19 23:05:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428153002/60001
4 years, 2 months ago (2016-10-20 17:14:56 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-20 20:43:23 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:22:04 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6a26fbb6476bd1f691396cef2236bf4369ac13ec
Cr-Commit-Position: refs/heads/master@{#426584}

Powered by Google App Engine
This is Rietveld 408576698