Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: chrome/browser/profiles/profile_impl_io_data.cc

Issue 2428143002: Clean up FtpTransactionFacory ownership. (Closed)
Patch Set: --typos Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profiles/profile_impl_io_data.h ('k') | chrome/browser/profiles/profile_io_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/profile_impl_io_data.cc
diff --git a/chrome/browser/profiles/profile_impl_io_data.cc b/chrome/browser/profiles/profile_impl_io_data.cc
index a2680af2597f5ad08869f40ecc01320ebabcebf7..0ef95436f2099fc191372e468a08daedd2a573af 100644
--- a/chrome/browser/profiles/profile_impl_io_data.cc
+++ b/chrome/browser/profiles/profile_impl_io_data.cc
@@ -63,7 +63,6 @@
#include "net/base/cache_type.h"
#include "net/base/sdch_manager.h"
#include "net/cookies/cookie_store.h"
-#include "net/ftp/ftp_network_layer.h"
#include "net/http/http_cache.h"
#include "net/http/http_network_session.h"
#include "net/http/http_server_properties_manager.h"
@@ -533,11 +532,6 @@ void ProfileImplIOData::InitializeInternal(
main_context_storage->set_http_transaction_factory(CreateMainHttpFactory(
main_context_storage->http_network_session(), std::move(main_backend)));
-#if !defined(DISABLE_FTP_SUPPORT)
- ftp_factory_.reset(
- new net::FtpNetworkLayer(io_thread_globals->host_resolver.get()));
-#endif // !defined(DISABLE_FTP_SUPPORT)
-
std::unique_ptr<net::URLRequestJobFactoryImpl> main_job_factory(
new net::URLRequestJobFactoryImpl());
InstallProtocolHandlers(main_job_factory.get(), protocol_handlers);
@@ -557,7 +551,8 @@ void ProfileImplIOData::InitializeInternal(
main_context_storage->set_job_factory(SetUpJobFactoryDefaults(
std::move(main_job_factory), std::move(request_interceptors),
std::move(profile_params->protocol_handler_interceptor),
- main_context->network_delegate(), ftp_factory_.get()));
+ main_context->network_delegate(),
+ io_thread_globals->host_resolver.get()));
main_context->set_network_quality_estimator(
io_thread_globals->network_quality_estimator.get());
@@ -618,7 +613,7 @@ void ProfileImplIOData::
std::move(extensions_job_factory),
content::URLRequestInterceptorScopedVector(),
std::unique_ptr<ProtocolHandlerRegistry::JobInterceptorFactory>(), NULL,
- ftp_factory_.get());
+ io_thread_globals->host_resolver.get());
extensions_context->set_job_factory(extensions_job_factory_.get());
}
@@ -708,11 +703,12 @@ net::URLRequestContext* ProfileImplIOData::InitializeAppRequestContext(
request_interceptors.insert(
request_interceptors.begin(),
data_reduction_proxy_io_data()->CreateInterceptor().release());
+
std::unique_ptr<net::URLRequestJobFactory> top_job_factory(
SetUpJobFactoryDefaults(
std::move(job_factory), std::move(request_interceptors),
- std::move(protocol_handler_interceptor),
- main_context->network_delegate(), ftp_factory_.get()));
+ std::move(protocol_handler_interceptor), context->network_delegate(),
+ context->host_resolver()));
context->SetJobFactory(std::move(top_job_factory));
return context;
« no previous file with comments | « chrome/browser/profiles/profile_impl_io_data.h ('k') | chrome/browser/profiles/profile_io_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698