Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: chrome/browser/profiles/profile_io_data.h

Issue 2428143002: Clean up FtpTransactionFacory ownership. (Closed)
Patch Set: Response to comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profiles/profile_impl_io_data.cc ('k') | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/profile_io_data.h
diff --git a/chrome/browser/profiles/profile_io_data.h b/chrome/browser/profiles/profile_io_data.h
index 0887443c62eda2a2bf72abcb81d1f619c9f5358c..d1dc30a03bcf14177daaeb099326a23a5f536af0 100644
--- a/chrome/browser/profiles/profile_io_data.h
+++ b/chrome/browser/profiles/profile_io_data.h
@@ -77,7 +77,6 @@ class ChannelIDService;
class ClientCertStore;
class CookieStore;
class CTVerifier;
-class FtpTransactionFactory;
class HttpServerProperties;
class HttpTransactionFactory;
class ProxyConfigService;
@@ -362,13 +361,20 @@ class ProfileIOData {
void InitializeOnUIThread(Profile* profile);
void ApplyProfileParamsToContext(net::URLRequestContext* context) const;
+ // Does common setup of the URLRequestJobFactories. Adds default
+ // ProtocolHandlers to |job_factory|, adds URLRequestIntercetors in front of
eroman 2016/10/19 17:15:15 typo on interceptors
mmenke 2016/10/19 17:20:36 Done.
+ // it as needed, and returns the result.
+ //
+ // |protocol_handler_interceptor is configured to intercept URLRequests
eroman 2016/10/19 17:15:15 missing close |
mmenke 2016/10/19 17:20:36 Done.
+ // before all other URLRequestInterceptors.
+ // |host_resolver| is needed to set up the FtpProtocolHandler.
std::unique_ptr<net::URLRequestJobFactory> SetUpJobFactoryDefaults(
std::unique_ptr<net::URLRequestJobFactoryImpl> job_factory,
content::URLRequestInterceptorScopedVector request_interceptors,
std::unique_ptr<ProtocolHandlerRegistry::JobInterceptorFactory>
protocol_handler_interceptor,
net::NetworkDelegate* network_delegate,
- net::FtpTransactionFactory* ftp_transaction_factory) const;
+ net::HostResolver* host_resolver) const;
// Called when the Profile is destroyed. |context_getters| must include all
// URLRequestContextGetters that refer to the ProfileIOData's
« no previous file with comments | « chrome/browser/profiles/profile_impl_io_data.cc ('k') | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698