Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/url_request/url_request_context_builder.cc

Issue 2428143002: Clean up FtpTransactionFacory ownership. (Closed)
Patch Set: Oops Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/url_request/ftp_protocol_handler.cc ('K') | « net/url_request/url_request_context_builder.h ('k') | net/url_request/url_request_ftp_job_unittest.cc » ('j') | net/url_request/url_request_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_context_builder.cc
diff --git a/net/url_request/url_request_context_builder.cc b/net/url_request/url_request_context_builder.cc
index fb4fd230736587af94bd12ee090484205d8388cc..f5c1eded31f2b03e8d5b0e9d1924a88180383c07 100644
--- a/net/url_request/url_request_context_builder.cc
+++ b/net/url_request/url_request_context_builder.cc
@@ -505,10 +505,8 @@ std::unique_ptr<URLRequestContext> URLRequestContextBuilder::Build() {
#if !defined(DISABLE_FTP_SUPPORT)
if (ftp_enabled_) {
- ftp_transaction_factory_.reset(
- new FtpNetworkLayer(context->host_resolver()));
- job_factory->SetProtocolHandler("ftp", base::MakeUnique<FtpProtocolHandler>(
- ftp_transaction_factory_.get()));
+ job_factory->SetProtocolHandler(
+ "ftp", FtpProtocolHandler::Create(context->host_resolver()));
}
#endif // !defined(DISABLE_FTP_SUPPORT)
« net/url_request/ftp_protocol_handler.cc ('K') | « net/url_request/url_request_context_builder.h ('k') | net/url_request/url_request_ftp_job_unittest.cc » ('j') | net/url_request/url_request_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698