Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: net/ftp/ftp_network_layer.cc

Issue 2428143002: Clean up FtpTransactionFacory ownership. (Closed)
Patch Set: --typos Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/profiles/profile_io_data.cc ('k') | net/url_request/ftp_protocol_handler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/ftp/ftp_network_layer.h" 5 #include "net/ftp/ftp_network_layer.h"
6 6
7 #include "base/logging.h"
7 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
8 #include "net/ftp/ftp_network_session.h" 9 #include "net/ftp/ftp_network_session.h"
9 #include "net/ftp/ftp_network_transaction.h" 10 #include "net/ftp/ftp_network_transaction.h"
10 #include "net/socket/client_socket_factory.h" 11 #include "net/socket/client_socket_factory.h"
11 12
12 namespace net { 13 namespace net {
13 14
14 FtpNetworkLayer::FtpNetworkLayer(HostResolver* host_resolver) 15 FtpNetworkLayer::FtpNetworkLayer(HostResolver* host_resolver)
15 : session_(new FtpNetworkSession(host_resolver)), 16 : session_(new FtpNetworkSession(host_resolver)),
16 suspended_(false) { 17 suspended_(false) {
18 DCHECK(host_resolver);
17 } 19 }
18 20
19 FtpNetworkLayer::~FtpNetworkLayer() { 21 FtpNetworkLayer::~FtpNetworkLayer() {
20 } 22 }
21 23
22 std::unique_ptr<FtpTransaction> FtpNetworkLayer::CreateTransaction() { 24 std::unique_ptr<FtpTransaction> FtpNetworkLayer::CreateTransaction() {
23 if (suspended_) 25 if (suspended_)
24 return std::unique_ptr<FtpTransaction>(); 26 return std::unique_ptr<FtpTransaction>();
25 27
26 return base::MakeUnique<FtpNetworkTransaction>( 28 return base::MakeUnique<FtpNetworkTransaction>(
27 session_->host_resolver(), ClientSocketFactory::GetDefaultFactory()); 29 session_->host_resolver(), ClientSocketFactory::GetDefaultFactory());
28 } 30 }
29 31
30 void FtpNetworkLayer::Suspend(bool suspend) { 32 void FtpNetworkLayer::Suspend(bool suspend) {
31 suspended_ = suspend; 33 suspended_ = suspend;
32 } 34 }
33 35
34 } // namespace net 36 } // namespace net
OLDNEW
« no previous file with comments | « chrome/browser/profiles/profile_io_data.cc ('k') | net/url_request/ftp_protocol_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698