Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: chrome/browser/io_thread.h

Issue 2428143002: Clean up FtpTransactionFacory ownership. (Closed)
Patch Set: --typos Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/io_thread.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_IO_THREAD_H_ 5 #ifndef CHROME_BROWSER_IO_THREAD_H_
6 #define CHROME_BROWSER_IO_THREAD_H_ 6 #define CHROME_BROWSER_IO_THREAD_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 namespace extensions { 67 namespace extensions {
68 class EventRouterForwarder; 68 class EventRouterForwarder;
69 } 69 }
70 70
71 namespace net { 71 namespace net {
72 class CTPolicyEnforcer; 72 class CTPolicyEnforcer;
73 class CertVerifier; 73 class CertVerifier;
74 class ChannelIDService; 74 class ChannelIDService;
75 class CookieStore; 75 class CookieStore;
76 class CTLogVerifier; 76 class CTLogVerifier;
77 class FtpTransactionFactory;
78 class HostMappingRules; 77 class HostMappingRules;
79 class HostResolver; 78 class HostResolver;
80 class HttpAuthHandlerRegistryFactory; 79 class HttpAuthHandlerRegistryFactory;
81 class HttpAuthPreferences; 80 class HttpAuthPreferences;
82 class HttpServerProperties; 81 class HttpServerProperties;
83 class HttpTransactionFactory; 82 class HttpTransactionFactory;
84 class HttpUserAgentSettings; 83 class HttpUserAgentSettings;
85 class LoggingNetworkChangeObserver; 84 class LoggingNetworkChangeObserver;
86 class NetworkDelegate; 85 class NetworkDelegate;
87 class NetworkQualityEstimator; 86 class NetworkQualityEstimator;
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 std::unique_ptr<net::CTVerifier> cert_transparency_verifier; 156 std::unique_ptr<net::CTVerifier> cert_transparency_verifier;
158 std::unique_ptr<net::CTPolicyEnforcer> ct_policy_enforcer; 157 std::unique_ptr<net::CTPolicyEnforcer> ct_policy_enforcer;
159 scoped_refptr<net::SSLConfigService> ssl_config_service; 158 scoped_refptr<net::SSLConfigService> ssl_config_service;
160 std::unique_ptr<net::HttpAuthHandlerFactory> http_auth_handler_factory; 159 std::unique_ptr<net::HttpAuthHandlerFactory> http_auth_handler_factory;
161 std::unique_ptr<net::HttpServerProperties> http_server_properties; 160 std::unique_ptr<net::HttpServerProperties> http_server_properties;
162 std::unique_ptr<net::ProxyService> proxy_script_fetcher_proxy_service; 161 std::unique_ptr<net::ProxyService> proxy_script_fetcher_proxy_service;
163 std::unique_ptr<net::HttpNetworkSession> 162 std::unique_ptr<net::HttpNetworkSession>
164 proxy_script_fetcher_http_network_session; 163 proxy_script_fetcher_http_network_session;
165 std::unique_ptr<net::HttpTransactionFactory> 164 std::unique_ptr<net::HttpTransactionFactory>
166 proxy_script_fetcher_http_transaction_factory; 165 proxy_script_fetcher_http_transaction_factory;
167 std::unique_ptr<net::FtpTransactionFactory>
168 proxy_script_fetcher_ftp_transaction_factory;
169 std::unique_ptr<net::URLRequestJobFactory> 166 std::unique_ptr<net::URLRequestJobFactory>
170 proxy_script_fetcher_url_request_job_factory; 167 proxy_script_fetcher_url_request_job_factory;
171 std::unique_ptr<net::HttpAuthPreferences> http_auth_preferences; 168 std::unique_ptr<net::HttpAuthPreferences> http_auth_preferences;
172 // TODO(willchan): Remove proxy script fetcher context since it's not 169 // TODO(willchan): Remove proxy script fetcher context since it's not
173 // necessary now that I got rid of refcounting URLRequestContexts. 170 // necessary now that I got rid of refcounting URLRequestContexts.
174 // 171 //
175 // The first URLRequestContext is |system_url_request_context|. We introduce 172 // The first URLRequestContext is |system_url_request_context|. We introduce
176 // |proxy_script_fetcher_context| for the second context. It has a direct 173 // |proxy_script_fetcher_context| for the second context. It has a direct
177 // ProxyService, since we always directly connect to fetch the PAC script. 174 // ProxyService, since we always directly connect to fetch the PAC script.
178 std::unique_ptr<net::URLRequestContext> proxy_script_fetcher_context; 175 std::unique_ptr<net::URLRequestContext> proxy_script_fetcher_context;
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 // Callback for updating data use prefs which needs to be initialized on UI 401 // Callback for updating data use prefs which needs to be initialized on UI
405 // thread and passed to |ChromeNetworkDelegate|. 402 // thread and passed to |ChromeNetworkDelegate|.
406 metrics::UpdateUsagePrefCallbackType metrics_data_use_forwarder_; 403 metrics::UpdateUsagePrefCallbackType metrics_data_use_forwarder_;
407 404
408 base::WeakPtrFactory<IOThread> weak_factory_; 405 base::WeakPtrFactory<IOThread> weak_factory_;
409 406
410 DISALLOW_COPY_AND_ASSIGN(IOThread); 407 DISALLOW_COPY_AND_ASSIGN(IOThread);
411 }; 408 };
412 409
413 #endif // CHROME_BROWSER_IO_THREAD_H_ 410 #endif // CHROME_BROWSER_IO_THREAD_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/io_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698