Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: chrome/browser/profiles/off_the_record_profile_io_data.h

Issue 2428143002: Clean up FtpTransactionFacory ownership. (Closed)
Patch Set: Response to comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PROFILES_OFF_THE_RECORD_PROFILE_IO_DATA_H_ 5 #ifndef CHROME_BROWSER_PROFILES_OFF_THE_RECORD_PROFILE_IO_DATA_H_
6 #define CHROME_BROWSER_PROFILES_OFF_THE_RECORD_PROFILE_IO_DATA_H_ 6 #define CHROME_BROWSER_PROFILES_OFF_THE_RECORD_PROFILE_IO_DATA_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/containers/hash_tables.h" 11 #include "base/containers/hash_tables.h"
12 #include "base/files/file_path.h" 12 #include "base/files/file_path.h"
13 #include "base/macros.h" 13 #include "base/macros.h"
14 #include "base/memory/ref_counted.h" 14 #include "base/memory/ref_counted.h"
15 #include "chrome/browser/custom_handlers/protocol_handler_registry.h" 15 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
16 #include "chrome/browser/profiles/profile_io_data.h" 16 #include "chrome/browser/profiles/profile_io_data.h"
17 #include "chrome/browser/profiles/storage_partition_descriptor.h" 17 #include "chrome/browser/profiles/storage_partition_descriptor.h"
18 18
19 class ChromeURLRequestContextGetter; 19 class ChromeURLRequestContextGetter;
20 class Profile; 20 class Profile;
21 21
22 namespace net { 22 namespace net {
23 class CookieStore; 23 class CookieStore;
24 class FtpTransactionFactory;
25 class SdchOwner; 24 class SdchOwner;
26 class URLRequestContext; 25 class URLRequestContext;
27 } // namespace net 26 } // namespace net
28 27
29 // OffTheRecordProfile owns a OffTheRecordProfileIOData::Handle, which holds a 28 // OffTheRecordProfile owns a OffTheRecordProfileIOData::Handle, which holds a
30 // reference to the OffTheRecordProfileIOData. OffTheRecordProfileIOData is 29 // reference to the OffTheRecordProfileIOData. OffTheRecordProfileIOData is
31 // intended to own all the objects owned by OffTheRecordProfile which live on 30 // intended to own all the objects owned by OffTheRecordProfile which live on
32 // the IO thread, such as, but not limited to, network objects like 31 // the IO thread, such as, but not limited to, network objects like
33 // CookieMonster, HttpTransactionFactory, etc. OffTheRecordProfileIOData is 32 // CookieMonster, HttpTransactionFactory, etc. OffTheRecordProfileIOData is
34 // owned by the OffTheRecordProfile and OffTheRecordProfileIOData's 33 // owned by the OffTheRecordProfile and OffTheRecordProfileIOData's
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 const StoragePartitionDescriptor& partition_descriptor, 132 const StoragePartitionDescriptor& partition_descriptor,
134 std::unique_ptr<ProtocolHandlerRegistry::JobInterceptorFactory> 133 std::unique_ptr<ProtocolHandlerRegistry::JobInterceptorFactory>
135 protocol_handler_interceptor, 134 protocol_handler_interceptor,
136 content::ProtocolHandlerMap* protocol_handlers, 135 content::ProtocolHandlerMap* protocol_handlers,
137 content::URLRequestInterceptorScopedVector request_interceptors) 136 content::URLRequestInterceptorScopedVector request_interceptors)
138 const override; 137 const override;
139 net::URLRequestContext* AcquireIsolatedMediaRequestContext( 138 net::URLRequestContext* AcquireIsolatedMediaRequestContext(
140 net::URLRequestContext* app_context, 139 net::URLRequestContext* app_context,
141 const StoragePartitionDescriptor& partition_descriptor) const override; 140 const StoragePartitionDescriptor& partition_descriptor) const override;
142 141
143 mutable std::unique_ptr<net::FtpTransactionFactory> ftp_factory_;
144
145 mutable std::unique_ptr<net::CookieStore> extensions_cookie_store_; 142 mutable std::unique_ptr<net::CookieStore> extensions_cookie_store_;
146 143
147 mutable std::unique_ptr<net::URLRequestJobFactory> extensions_job_factory_; 144 mutable std::unique_ptr<net::URLRequestJobFactory> extensions_job_factory_;
148 145
149 mutable std::unique_ptr<net::SdchOwner> sdch_policy_; 146 mutable std::unique_ptr<net::SdchOwner> sdch_policy_;
150 147
151 DISALLOW_COPY_AND_ASSIGN(OffTheRecordProfileIOData); 148 DISALLOW_COPY_AND_ASSIGN(OffTheRecordProfileIOData);
152 }; 149 };
153 150
154 #endif // CHROME_BROWSER_PROFILES_OFF_THE_RECORD_PROFILE_IO_DATA_H_ 151 #endif // CHROME_BROWSER_PROFILES_OFF_THE_RECORD_PROFILE_IO_DATA_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698