Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: net/url_request/url_request_context_builder.h

Issue 2428143002: Clean up FtpTransactionFacory ownership. (Closed)
Patch Set: Oops Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This class is useful for building a simple URLRequestContext. Most creators 5 // This class is useful for building a simple URLRequestContext. Most creators
6 // of new URLRequestContexts should use this helper class to construct it. Call 6 // of new URLRequestContexts should use this helper class to construct it. Call
7 // any configuration params, and when done, invoke Build() to construct the 7 // any configuration params, and when done, invoke Build() to construct the
8 // URLRequestContext. This URLRequestContext will own all its own storage. 8 // URLRequestContext. This URLRequestContext will own all its own storage.
9 // 9 //
10 // URLRequestContextBuilder and its associated params classes are initially 10 // URLRequestContextBuilder and its associated params classes are initially
(...skipping 338 matching lines...) Expand 10 before | Expand all | Expand 10 after
349 HttpNetworkSessionParams http_network_session_params_; 349 HttpNetworkSessionParams http_network_session_params_;
350 base::FilePath transport_security_persister_path_; 350 base::FilePath transport_security_persister_path_;
351 NetLog* net_log_; 351 NetLog* net_log_;
352 std::unique_ptr<HostResolver> host_resolver_; 352 std::unique_ptr<HostResolver> host_resolver_;
353 std::unique_ptr<ChannelIDService> channel_id_service_; 353 std::unique_ptr<ChannelIDService> channel_id_service_;
354 std::unique_ptr<ProxyConfigService> proxy_config_service_; 354 std::unique_ptr<ProxyConfigService> proxy_config_service_;
355 std::unique_ptr<ProxyService> proxy_service_; 355 std::unique_ptr<ProxyService> proxy_service_;
356 std::unique_ptr<NetworkDelegate> network_delegate_; 356 std::unique_ptr<NetworkDelegate> network_delegate_;
357 std::unique_ptr<ProxyDelegate> proxy_delegate_; 357 std::unique_ptr<ProxyDelegate> proxy_delegate_;
358 std::unique_ptr<CookieStore> cookie_store_; 358 std::unique_ptr<CookieStore> cookie_store_;
359 #if !defined(DISABLE_FTP_SUPPORT)
360 std::unique_ptr<FtpTransactionFactory> ftp_transaction_factory_;
361 #endif
362 std::unique_ptr<HttpAuthHandlerFactory> http_auth_handler_factory_; 359 std::unique_ptr<HttpAuthHandlerFactory> http_auth_handler_factory_;
363 std::unique_ptr<CertVerifier> cert_verifier_; 360 std::unique_ptr<CertVerifier> cert_verifier_;
364 std::unique_ptr<CTVerifier> ct_verifier_; 361 std::unique_ptr<CTVerifier> ct_verifier_;
365 std::vector<std::unique_ptr<URLRequestInterceptor>> url_request_interceptors_; 362 std::vector<std::unique_ptr<URLRequestInterceptor>> url_request_interceptors_;
366 std::unique_ptr<HttpServerProperties> http_server_properties_; 363 std::unique_ptr<HttpServerProperties> http_server_properties_;
367 std::map<std::string, std::unique_ptr<URLRequestJobFactory::ProtocolHandler>> 364 std::map<std::string, std::unique_ptr<URLRequestJobFactory::ProtocolHandler>>
368 protocol_handlers_; 365 protocol_handlers_;
369 // SocketPerformanceWatcherFactory to be used by this context builder. 366 // SocketPerformanceWatcherFactory to be used by this context builder.
370 // Not owned by the context builder. Once it is set to a non-null value, it 367 // Not owned by the context builder. Once it is set to a non-null value, it
371 // is guaranteed to be non-null during the lifetime of |this|. 368 // is guaranteed to be non-null during the lifetime of |this|.
372 SocketPerformanceWatcherFactory* socket_performance_watcher_factory_; 369 SocketPerformanceWatcherFactory* socket_performance_watcher_factory_;
373 370
374 DISALLOW_COPY_AND_ASSIGN(URLRequestContextBuilder); 371 DISALLOW_COPY_AND_ASSIGN(URLRequestContextBuilder);
375 }; 372 };
376 373
377 } // namespace net 374 } // namespace net
378 375
379 #endif // NET_URL_REQUEST_URL_REQUEST_CONTEXT_BUILDER_H_ 376 #endif // NET_URL_REQUEST_URL_REQUEST_CONTEXT_BUILDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698