Clean up FtpTransactionFacory ownership.

chrome/browser/profiles/profile_io_data.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 59 matching lines @@
 class ExtensionThrottleManager;
 class InfoMap;
 }
 
 namespace net {
 class CertVerifier;
 class ChannelIDService;
 class ClientCertStore;
 class CookieStore;
 class CTVerifier;
-class FtpTransactionFactory;
 class HttpServerProperties;
 class HttpTransactionFactory;
 class ProxyConfigService;
 class ProxyService;
 class ReportSender;
 class SSLConfigService;
 class TransportSecurityPersister;
 class TransportSecurityState;
 class URLRequestContextStorage;
 class URLRequestJobFactoryImpl;
@@ skipping 264 matching lines @@
     // ensure it's not accidently used on the IO thread. Before using it on the
     // UI thread, call ProfileManager::IsValidProfile to ensure it's alive.
     void* profile;
   };
 
   explicit ProfileIOData(Profile::ProfileType profile_type);
 
   void InitializeOnUIThread(Profile* profile);
   void ApplyProfileParamsToContext(net::URLRequestContext* context) const;
 
   std::unique_ptr<net::URLRequestJobFactory> SetUpJobFactoryDefaults(

[eroman, 2016/10/19 16:29:51]

Can you add comments for this? In particular, would be nice to explain the role
of |host_resolver|, which is really just used for setting up ftp right now.

[mmenke, 2016/10/19 17:09:35]

Good idea, done.  Also added a little more general documentation (Though less
than the method really needs)

       std::unique_ptr<net::URLRequestJobFactoryImpl> job_factory,
       content::URLRequestInterceptorScopedVector request_interceptors,
       std::unique_ptr<ProtocolHandlerRegistry::JobInterceptorFactory>
           protocol_handler_interceptor,
       net::NetworkDelegate* network_delegate,
-      net::FtpTransactionFactory* ftp_transaction_factory) const;
+      net::HostResolver* host_resolver) const;
 
   // Called when the Profile is destroyed. |context_getters| must include all
   // URLRequestContextGetters that refer to the ProfileIOData's
   // URLRequestContexts. Triggers destruction of the ProfileIOData and shuts
   // down |context_getters| safely on the IO thread.
   // TODO(mmenke):  Passing all those URLRequestContextGetters around like this
   //     is really silly.  Can we do something cleaner?
   void ShutdownOnUIThread(
       std::unique_ptr<ChromeURLRequestContextGetterVector> context_getters);
 
@@ skipping 242 matching lines @@
   mutable std::unique_ptr<certificate_transparency::TreeStateTracker>
       ct_tree_tracker_;
   mutable base::Closure ct_tree_tracker_unregistration_;
 
   const Profile::ProfileType profile_type_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileIOData);
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_