Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2428043002: [heap] Start sweeper tasks after evacuation. (Closed)

Created:
4 years, 2 months ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Start sweeper tasks after evacuation. This allows us to use more tasks for parallel evacuation. BUG= Committed: https://crrev.com/9eff39aebf18bf9a42106579e1d81f7be4f0f299 Cr-Commit-Position: refs/heads/master@{#40444}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -75 lines) Patch
M src/heap/incremental-marking.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.h View 4 chunks +10 lines, -24 lines 0 comments Download
M src/heap/mark-compact.cc View 12 chunks +34 lines, -43 lines 0 comments Download
M src/heap/spaces.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/heap/spaces.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ulan
ptal
4 years, 2 months ago (2016-10-18 15:54:04 UTC) #3
Michael Lippautz
lgtm https://codereview.chromium.org/2428043002/diff/1/src/heap/spaces.cc File src/heap/spaces.cc (right): https://codereview.chromium.org/2428043002/diff/1/src/heap/spaces.cc#newcode405 src/heap/spaces.cc:405: chunk->SweepingDone(); I think (mc == nullptr) can go.
4 years, 2 months ago (2016-10-18 16:02:39 UTC) #4
ulan
https://codereview.chromium.org/2428043002/diff/1/src/heap/spaces.cc File src/heap/spaces.cc (right): https://codereview.chromium.org/2428043002/diff/1/src/heap/spaces.cc#newcode405 src/heap/spaces.cc:405: chunk->SweepingDone(); On 2016/10/18 16:02:39, Michael Lippautz wrote: > I ...
4 years, 2 months ago (2016-10-18 16:07:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2428043002/20001
4 years, 2 months ago (2016-10-19 14:42:15 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 15:11:11 UTC) #10
ulan
A revert of this CL (patchset #2 id:20001) has been created in https://chromiumcodereview.appspot.com/2440693002/ by ulan@chromium.org. ...
4 years, 2 months ago (2016-10-20 12:14:45 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:06:56 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9eff39aebf18bf9a42106579e1d81f7be4f0f299
Cr-Commit-Position: refs/heads/master@{#40444}

Powered by Google App Engine
This is Rietveld 408576698