Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2427953002: [compiler] Ship Ignition for all TurboFan code. (Closed)

Created:
4 years, 2 months ago by Michael Starzinger
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Ship Ignition for all TurboFan code. This enables Ignition unconditionally for all code that is destined for optimization with TurboFan. This ensures all optimization attempts will go through the BytecodeGraphBuilder and that the AstGraphBuilder pipe is dried out in practice. R=mvstanton@chromium.org Committed: https://crrev.com/20d29ff03668cf5ac52db4d2208a0351328ba568 Cr-Commit-Position: refs/heads/master@{#40462}

Patch Set 1 #

Patch Set 2 : Fix comment. #

Patch Set 3 : Fix self-nit. #

Patch Set 4 : Fix one more test. #

Patch Set 5 : Fix more expectations. #

Patch Set 6 : Fix "fail" vs "crash". #

Patch Set 7 : Fix better. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -90 lines) Patch
M src/api.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/bootstrapper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 1 4 chunks +35 lines, -35 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/d8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/frames.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/log.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/cctest.status View 1 2 3 4 5 6 3 chunks +23 lines, -13 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 4 3 chunks +5 lines, -8 lines 0 comments Download
M test/mjsunit/wasm/compiled-module-management.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (22 generated)
Michael Starzinger
4 years, 2 months ago (2016-10-18 12:12:29 UTC) #3
Benedikt Meurer
Very nice! LGTM form my side.
4 years, 2 months ago (2016-10-18 12:22:02 UTC) #5
mvstanton
LGTM.
4 years, 2 months ago (2016-10-18 12:28:54 UTC) #8
Hannes Payer (out of office)
heap lgtm
4 years, 2 months ago (2016-10-20 07:25:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427953002/120001
4 years, 2 months ago (2016-10-20 10:53:21 UTC) #25
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 2 months ago (2016-10-20 10:57:28 UTC) #26
Michael Achenbach
Would usually revert this with the following message... Breaks: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10820 See also: https://github.com/v8/v8/wiki/Blink-layout-tests ... but ...
4 years, 2 months ago (2016-10-20 12:40:22 UTC) #28
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:07:49 UTC) #30
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/20d29ff03668cf5ac52db4d2208a0351328ba568
Cr-Commit-Position: refs/heads/master@{#40462}

Powered by Google App Engine
This is Rietveld 408576698