Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

Issue 2427893003: Fix wrong cast in ExtensionsGuestViewContainer. (Closed)
Patch Set: remove cast Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
diff --git a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
index a35eaee36eeddb990c3b6cb2e0de5b3f6f630810..060573ee1ca52f5cbe8d4729e37f541a80e3cf0d 100644
--- a/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
+++ b/extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc
@@ -249,8 +249,7 @@ void GuestViewInternalCustomBindings::AttachIframeGuest(
// An element instance ID uniquely identifies an IframeGuestViewContainer
// within a RenderView.
auto* guest_view_container =
- static_cast<guest_view::IframeGuestViewContainer*>(
- guest_view::GuestViewContainer::FromID(element_instance_id));
+ guest_view::GuestViewContainer::FromID(element_instance_id);
// This is the first time we hear about the |element_instance_id|.
DCHECK(!guest_view_container);
// The <webview> element's GC takes ownership of |guest_view_container|.
@@ -382,8 +381,8 @@ void GuestViewInternalCustomBindings::RegisterElementResizeCallback(
int element_instance_id = args[0]->Int32Value();
// An element instance ID uniquely identifies a ExtensionsGuestViewContainer
// within a RenderView.
- auto* guest_view_container = static_cast<ExtensionsGuestViewContainer*>(
- guest_view::GuestViewContainer::FromID(element_instance_id));
+ auto* guest_view_container =
+ guest_view::GuestViewContainer::FromID(element_instance_id);
if (!guest_view_container)
return;

Powered by Google App Engine
This is Rietveld 408576698