Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: extensions/renderer/guest_view/extensions_guest_view_container.h

Issue 2427893003: Fix wrong cast in ExtensionsGuestViewContainer. (Closed)
Patch Set: remove cast Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_RENDERER_GUEST_VIEW_EXTENSIONS_GUEST_VIEW_CONTAINER_H_ 5 #ifndef EXTENSIONS_RENDERER_GUEST_VIEW_EXTENSIONS_GUEST_VIEW_CONTAINER_H_
6 #define EXTENSIONS_RENDERER_GUEST_VIEW_EXTENSIONS_GUEST_VIEW_CONTAINER_H_ 6 #define EXTENSIONS_RENDERER_GUEST_VIEW_EXTENSIONS_GUEST_VIEW_CONTAINER_H_
7 7
8 #include <queue> 8 #include <queue>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "components/guest_view/renderer/guest_view_container.h" 11 #include "components/guest_view/renderer/guest_view_container.h"
12 #include "v8/include/v8.h" 12 #include "v8/include/v8.h"
13 13
14 namespace gfx { 14 namespace gfx {
15 class Size; 15 class Size;
16 } 16 }
17 17
18 namespace extensions { 18 namespace extensions {
19 19
20 class ExtensionsGuestViewContainer : public guest_view::GuestViewContainer { 20 class ExtensionsGuestViewContainer : public guest_view::GuestViewContainer {
21 public: 21 public:
22 explicit ExtensionsGuestViewContainer(content::RenderFrame* render_frame); 22 explicit ExtensionsGuestViewContainer(content::RenderFrame* render_frame);
23 23
24 void RegisterElementResizeCallback(v8::Local<v8::Function> callback,
25 v8::Isolate* isolate);
26
27 // BrowserPluginDelegate implementation.
28 void DidResizeElement(const gfx::Size& new_size) override;
29
30 protected: 24 protected:
31 ~ExtensionsGuestViewContainer() override; 25 ~ExtensionsGuestViewContainer() override;
32 26
33 private: 27 private:
34 void CallElementResizeCallback(const gfx::Size& new_size);
35
36 // GuestViewContainer implementation. 28 // GuestViewContainer implementation.
37 void OnDestroy(bool embedder_frame_destroyed) override; 29 void OnDestroy(bool embedder_frame_destroyed) override;
38 30
39 v8::Global<v8::Function> element_resize_callback_;
40 v8::Isolate* element_resize_isolate_;
41
42 // Weak pointer factory used for calling the element resize callback.
43 base::WeakPtrFactory<ExtensionsGuestViewContainer> weak_ptr_factory_;
44
45 DISALLOW_COPY_AND_ASSIGN(ExtensionsGuestViewContainer); 31 DISALLOW_COPY_AND_ASSIGN(ExtensionsGuestViewContainer);
46 }; 32 };
47 33
48 } // namespace extensions 34 } // namespace extensions
49 35
50 #endif // EXTENSIONS_RENDERER_GUEST_VIEW_EXTENSIONS_GUEST_VIEW_CONTAINER_H_ 36 #endif // EXTENSIONS_RENDERER_GUEST_VIEW_EXTENSIONS_GUEST_VIEW_CONTAINER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698