Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2427883003: Remove usage of FOR_EACH_OBSERVER macro in headless domain_cc.template (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in headless domain_cc.template Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/2cc834266d6a53ac9ceca591e5463b937bef4b1a Cr-Commit-Position: refs/heads/master@{#426771}

Patch Set 1 #

Patch Set 2 : braces #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M headless/lib/browser/domain_cc.template View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
Eric Willigers
4 years, 2 months ago (2016-10-18 22:50:22 UTC) #3
Eric Willigers
4 years, 2 months ago (2016-10-18 22:51:08 UTC) #6
alex clarke (OOO till 29th)
lgtm
4 years, 2 months ago (2016-10-21 11:26:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427883003/20001
4 years, 2 months ago (2016-10-21 11:28:22 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-21 11:44:14 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:28:52 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2cc834266d6a53ac9ceca591e5463b937bef4b1a
Cr-Commit-Position: refs/heads/master@{#426771}

Powered by Google App Engine
This is Rietveld 408576698