Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2427883002: Remove IDC_BACK_TO_CALLING_APP which is now obsolete (Closed)

Created:
4 years, 2 months ago by pkl (ping after 24h if needed)
Modified:
4 years, 2 months ago
Reviewers:
justincohen
CC:
chromium-reviews, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove IDC_BACK_TO_CALLING_APP which is now obsolete This depends on https://chromereviews.googleplex.com/523537014 which deleted the code for Back to Calling App button. BUG=633626 Committed: https://crrev.com/c8f0c13315226f78b1a3b4779f70feb9bf2495d1 Cr-Commit-Position: refs/heads/master@{#426490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ios/chrome/browser/ui/commands/ios_command_ids.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
justincohen
s/no/now
4 years, 2 months ago (2016-10-18 20:18:09 UTC) #2
pkl (ping after 24h if needed)
https://chromereviews.googleplex.com/523537014/ has been submitted. There are no more references to IDC_BACK_TO_CALLING_APP. Please review this CL.
4 years, 2 months ago (2016-10-19 22:22:24 UTC) #4
justincohen
LGTM!
4 years, 2 months ago (2016-10-20 15:38:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427883002/1
4 years, 2 months ago (2016-10-20 15:49:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 16:16:28 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:18:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8f0c13315226f78b1a3b4779f70feb9bf2495d1
Cr-Commit-Position: refs/heads/master@{#426490}

Powered by Google App Engine
This is Rietveld 408576698