Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Side by Side Diff: chrome/browser/engagement/site_engagement_service.h

Issue 2427343002: Make the site engagement service more robust to clock changes and time inconsistencies. (Closed)
Patch Set: Address nit Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/engagement/site_engagement_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ENGAGEMENT_SITE_ENGAGEMENT_SERVICE_H_ 5 #ifndef CHROME_BROWSER_ENGAGEMENT_SITE_ENGAGEMENT_SERVICE_H_
6 #define CHROME_BROWSER_ENGAGEMENT_SITE_ENGAGEMENT_SERVICE_H_ 6 #define CHROME_BROWSER_ENGAGEMENT_SITE_ENGAGEMENT_SERVICE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <memory> 9 #include <memory>
10 #include <set> 10 #include <set>
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 131
132 // Overridden from SiteEngagementScoreProvider. 132 // Overridden from SiteEngagementScoreProvider.
133 double GetScore(const GURL& url) const override; 133 double GetScore(const GURL& url) const override;
134 double GetTotalEngagementPoints() const override; 134 double GetTotalEngagementPoints() const override;
135 135
136 private: 136 private:
137 friend class SiteEngagementObserver; 137 friend class SiteEngagementObserver;
138 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, CheckHistograms); 138 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, CheckHistograms);
139 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, CleanupEngagementScores); 139 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, CleanupEngagementScores);
140 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, 140 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest,
141 CleanupMovesScoreBackToNow);
142 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest,
143 CleanupMovesScoreBackToRebase);
144 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest,
141 CleanupEngagementScoresProportional); 145 CleanupEngagementScoresProportional);
142 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, ClearHistoryForURLs); 146 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, ClearHistoryForURLs);
143 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, GetMedianEngagement); 147 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, GetMedianEngagement);
144 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, GetTotalNavigationPoints); 148 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, GetTotalNavigationPoints);
145 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, GetTotalUserInputPoints); 149 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, GetTotalUserInputPoints);
146 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, LastShortcutLaunch); 150 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, LastShortcutLaunch);
147 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, 151 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest,
148 CleanupOriginsOnHistoryDeletion); 152 CleanupOriginsOnHistoryDeletion);
149 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, IsBootstrapped); 153 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, IsBootstrapped);
150 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, EngagementLevel); 154 FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, EngagementLevel);
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 // A list of observers. When any origin registers an engagement-increasing 259 // A list of observers. When any origin registers an engagement-increasing
256 // event, each observer's OnEngagementIncreased method will be called. 260 // event, each observer's OnEngagementIncreased method will be called.
257 base::ObserverList<SiteEngagementObserver> observer_list_; 261 base::ObserverList<SiteEngagementObserver> observer_list_;
258 262
259 base::WeakPtrFactory<SiteEngagementService> weak_factory_; 263 base::WeakPtrFactory<SiteEngagementService> weak_factory_;
260 264
261 DISALLOW_COPY_AND_ASSIGN(SiteEngagementService); 265 DISALLOW_COPY_AND_ASSIGN(SiteEngagementService);
262 }; 266 };
263 267
264 #endif // CHROME_BROWSER_ENGAGEMENT_SITE_ENGAGEMENT_SERVICE_H_ 268 #endif // CHROME_BROWSER_ENGAGEMENT_SITE_ENGAGEMENT_SERVICE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/engagement/site_engagement_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698