Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: chrome/browser/devtools/devtools_window.h

Issue 2427323005: Fix certificate viewer not showing up for subresources if the devtools window is docked. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 5 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
6 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 6 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "chrome/browser/devtools/devtools_contents_resizing_strategy.h" 9 #include "chrome/browser/devtools/devtools_contents_resizing_strategy.h"
10 #include "chrome/browser/devtools/devtools_toggle_action.h" 10 #include "chrome/browser/devtools/devtools_toggle_action.h"
(...skipping 288 matching lines...) Expand 10 before | Expand all | Expand 10 after
299 content::JavaScriptDialogManager* GetJavaScriptDialogManager( 299 content::JavaScriptDialogManager* GetJavaScriptDialogManager(
300 content::WebContents* source) override; 300 content::WebContents* source) override;
301 content::ColorChooser* OpenColorChooser( 301 content::ColorChooser* OpenColorChooser(
302 content::WebContents* web_contents, 302 content::WebContents* web_contents,
303 SkColor color, 303 SkColor color,
304 const std::vector<content::ColorSuggestion>& suggestions) override; 304 const std::vector<content::ColorSuggestion>& suggestions) override;
305 void RunFileChooser(content::RenderFrameHost* render_frame_host, 305 void RunFileChooser(content::RenderFrameHost* render_frame_host,
306 const content::FileChooserParams& params) override; 306 const content::FileChooserParams& params) override;
307 bool PreHandleGestureEvent(content::WebContents* source, 307 bool PreHandleGestureEvent(content::WebContents* source,
308 const blink::WebGestureEvent& event) override; 308 const blink::WebGestureEvent& event) override;
309 void ShowCertificateViewerInDevTools(
310 content::WebContents* web_contents,
311 scoped_refptr<net::X509Certificate> certificate) override;
309 312
310 // content::DevToolsUIBindings::Delegate overrides 313 // content::DevToolsUIBindings::Delegate overrides
311 void ActivateWindow() override; 314 void ActivateWindow() override;
312 void CloseWindow() override; 315 void CloseWindow() override;
313 void Inspect(scoped_refptr<content::DevToolsAgentHost> host) override; 316 void Inspect(scoped_refptr<content::DevToolsAgentHost> host) override;
314 void SetInspectedPageBounds(const gfx::Rect& rect) override; 317 void SetInspectedPageBounds(const gfx::Rect& rect) override;
315 void InspectElementCompleted() override; 318 void InspectElementCompleted() override;
316 void SetIsDocked(bool is_docked) override; 319 void SetIsDocked(bool is_docked) override;
317 void OpenInNewTab(const std::string& url) override; 320 void OpenInNewTab(const std::string& url) override;
318 void SetWhitelistedShortcuts(const std::string& message) override; 321 void SetWhitelistedShortcuts(const std::string& message) override;
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 base::Closure ready_for_test_callback_; 355 base::Closure ready_for_test_callback_;
353 356
354 base::TimeTicks inspect_element_start_time_; 357 base::TimeTicks inspect_element_start_time_;
355 std::unique_ptr<DevToolsEventForwarder> event_forwarder_; 358 std::unique_ptr<DevToolsEventForwarder> event_forwarder_;
356 359
357 friend class DevToolsEventForwarder; 360 friend class DevToolsEventForwarder;
358 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow); 361 DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
359 }; 362 };
360 363
361 #endif // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_ 364 #endif // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698