Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2427323005: Fix certificate viewer not showing up for subresources if the devtools window is docked. (Closed)

Created:
4 years, 2 months ago by jam
Modified:
4 years, 2 months ago
Reviewers:
pfeldman, estark
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix certificate viewer not showing up for subresources if the devtools window is docked. BUG=657270 Committed: https://crrev.com/2697c72ef37e963d6cb465780683901833f59a6a Cr-Commit-Position: refs/heads/master@{#426917}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/devtools/devtools_window.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
jam
4 years, 2 months ago (2016-10-21 21:48:23 UTC) #9
pfeldman
lgtm, thanks.
4 years, 2 months ago (2016-10-21 21:55:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427323005/20001
4 years, 2 months ago (2016-10-21 22:10:05 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-10-21 22:33:32 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 22:36:34 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2697c72ef37e963d6cb465780683901833f59a6a
Cr-Commit-Position: refs/heads/master@{#426917}

Powered by Google App Engine
This is Rietveld 408576698