Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2427323004: Mojo JS bindings: Fix codec names for nested enum definitions (Closed)

Created:
4 years, 2 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 2 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo JS bindings: Fix codec names for nested enum definitions BUG=581390 TBR=yzshen@chromium.org Committed: https://crrev.com/f7a5012eb2eb97eefee9f925c4c628eb0bd1de83 Cr-Commit-Position: refs/heads/master@{#426657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M mojo/public/tools/bindings/generators/mojom_js_generator.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427323004/1
4 years, 2 months ago (2016-10-20 22:47:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 00:12:11 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:24:54 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f7a5012eb2eb97eefee9f925c4c628eb0bd1de83
Cr-Commit-Position: refs/heads/master@{#426657}

Powered by Google App Engine
This is Rietveld 408576698