Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2427293003: Fix calls to element.animate() with positive delays not being composited (Closed)

Created:
4 years, 2 months ago by alancutter (OOO until 2018)
Modified:
4 years, 2 months ago
Reviewers:
dstockwell, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans, loyso (OOO)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix calls to element.animate() with positive delays not being composited We were only snapshotting compositor keyframes when there was an animation update. In the case of element.animate() with a positive delay there's no CSS animation change to the animation engine nor are there any effects to be applied. Previously we would early out in this situation, this change ensures we still look for KeyframeEffects that require compositor snapshotting. BUG=657242 Committed: https://crrev.com/7c2e9fef72cd494e3a09599697f015b8ef192fb4 Cr-Commit-Position: refs/heads/master@{#426404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2 lines) Patch
A third_party/WebKit/LayoutTests/virtual/threaded/animations/element-animate-positive-delay.html View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
alancutter (OOO until 2018)
4 years, 2 months ago (2016-10-19 04:36:02 UTC) #2
rune
lgtm
4 years, 2 months ago (2016-10-19 07:52:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427293003/1
4 years, 2 months ago (2016-10-20 00:20:41 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/247111)
4 years, 2 months ago (2016-10-20 02:38:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427293003/1
4 years, 2 months ago (2016-10-20 03:32:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-20 04:38:38 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:15:35 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c2e9fef72cd494e3a09599697f015b8ef192fb4
Cr-Commit-Position: refs/heads/master@{#426404}

Powered by Google App Engine
This is Rietveld 408576698