Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 2427283004: [interpreter] Also optimize small functions earlier. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Also optimize small functions earlier. For fullcodegen the RuntimeProfiler has a shortcut that allows it to tier up small functions earlier, when enough type feedback is available. Port the same optimization for the Ignition+TurboFan pipeline. R=mstarzinger@chromium.org Committed: https://crrev.com/b888150afd6f5d83f4a110315bea6c9ca72fd912 Cr-Commit-Position: refs/heads/master@{#40435}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M src/runtime-profiler.cc View 2 chunks +13 lines, -2 lines 2 comments Download

Messages

Total messages: 14 (6 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-19 12:00:32 UTC) #1
Benedikt Meurer
Hey Michi, Mythri, Here's a port of the FCG functionality. Fixes some of the slowness ...
4 years, 2 months ago (2016-10-19 12:01:26 UTC) #5
Michael Starzinger
LGTM.
4 years, 2 months ago (2016-10-19 12:08:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2427283004/1
4 years, 2 months ago (2016-10-19 12:27:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 13:11:55 UTC) #10
mythria
lgtm with one comment more for my understanding. https://codereview.chromium.org/2427283004/diff/1/src/runtime-profiler.cc File src/runtime-profiler.cc (right): https://codereview.chromium.org/2427283004/diff/1/src/runtime-profiler.cc#newcode429 src/runtime-profiler.cc:429: // ...
4 years, 2 months ago (2016-10-19 13:17:30 UTC) #11
Benedikt Meurer
https://codereview.chromium.org/2427283004/diff/1/src/runtime-profiler.cc File src/runtime-profiler.cc (right): https://codereview.chromium.org/2427283004/diff/1/src/runtime-profiler.cc#newcode429 src/runtime-profiler.cc:429: // If no IC was patched since the last ...
4 years, 2 months ago (2016-10-19 13:19:41 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:06:32 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b888150afd6f5d83f4a110315bea6c9ca72fd912
Cr-Commit-Position: refs/heads/master@{#40435}

Powered by Google App Engine
This is Rietveld 408576698